fix: check both CLI and value

solracsf · web-flow · commit 372c9d2ee6e3 · 2024-07-08T15:09:29.000+02:00
Signed-off-by: Git'Fellow &lt;12234510+solracsf@users.noreply.github.com&gt;
diff --git a/apps/settings/lib/SetupChecks/PhpOpcacheSetup.php b/apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
@@ -115,7 +115,7 @@ protected function getOpcacheSetupRecommendations(): array {
 
 	public function run(): SetupResult {
 		// Skip OPcache checks if running from CLI
-		if (PHP_SAPI === 'cli') {
+		if (OC::$CLI && !$this->iniGetWrapper->getBool('opcache.enable_cli')) {
 			return SetupResult::success($this->l10n->t('Checking from CLI, OPcache checks have been skipped.'));
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ protected function getOpcacheSetupRecommendations(): array {`
`115`	`115`
`116`	`116`	`public function run(): SetupResult {`
`117`	`117`	`// Skip OPcache checks if running from CLI`
`118`		`- if (PHP_SAPI === 'cli') {`
	`118`	`+ if (OC::$CLI && !$this->iniGetWrapper->getBool('opcache.enable_cli')) {`
`119`	`119`	`return SetupResult::success($this->l10n->t('Checking from CLI, OPcache checks have been skipped.'));`
`120`	`120`	`}`
`121`	`121`