refactor(recent-search): use order by fields to determine extended cache join and cast config limit to number

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

Author: cristianscheid

apps/files/src/services/Recent.ts

@@ -41,7 +41,7 @@ export async function getContents(path = '/', options: { signal: AbortSignal }):
 		const contentsResponse = await client.search('/', {
 			signal: options.signal,
 			details: true,
-			data: getRecentSearch(lastTwoWeeksTimestamp, store.userConfig.recent_files_limit + 1),
+			data: getRecentSearchCustom(lastTwoWeeksTimestamp, Number(store.userConfig.recent_files_limit)),
 		}) as ResponseDataDetailed<SearchResult>
 
 		const contents = contentsResponse.data.results

dist/files-init.js

@@ -153,7 +153,13 @@ public function searchInCaches(ISearchQuery $searchQuery, array $caches): array
 
 		$requestedFields = $this->searchBuilder->extractRequestedFields($searchQuery->getSearchOperation());
 
-		$query = $builder->selectFileCache('file', true);
+		$orderFields = array_map(fn($order) => $order->getField(), $searchQuery->getOrder());
+
+		$joinExtendedCache = in_array('creation_time', $requestedFields)
+			|| in_array('upload_time', $requestedFields)
+			|| in_array('last_activity', $orderFields);
+
+		$query = $builder->selectFileCache('file', $joinExtendedCache);
 
 		if (in_array('systemtag', $requestedFields)) {
 			$this->equipQueryForSystemTags($query, $this->requireUser($searchQuery));