test(settings): exclude the group caption from group-row selectors

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>

Author: pringelmann

apps/settings/src/components/AppNavigationGroupList.spec.ts

@@ -7,6 +7,7 @@ import { mount } from '@vue/test-utils'
 import { describe, expect, it, vi } from 'vitest'
 import { ref } from 'vue'
 import NcAppNavigationCaption from '@nextcloud/vue/components/NcAppNavigationCaption'
+import AppNavigationGroupList from './AppNavigationGroupList.vue'
 
 // The component builds a real Vuex store via useStore(); mock it so this stays
 // a focused component test that controls its own data.
@@ -38,8 +39,6 @@ vi.mock('@vueuse/core', async (importActual) => ({
 	useElementVisibility: () => ref(false),
 }))
 
-import AppNavigationGroupList from './AppNavigationGroupList.vue'
-
 describe('AppNavigationGroupList', () => {
 	it('does not expose the group list as a heading (BITV 9.1.3.1a)', () => {
 		const wrapper = mount(AppNavigationGroupList)

cypress/e2e/settings/users_groups.cy.ts

@@ -163,6 +163,7 @@ describe('Settings: Delete an empty group', { testIsolation: false }, () => {
 		// see that the list of groups does not contain the group
 		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]')
 			.find('li')
+			.not('.app-navigation-caption')
 			.should('not.exist')
 		// and also not in database
 		cy.runOccCommand('group:list --output=json').then(($response) => {
@@ -219,6 +220,7 @@ describe('Settings: Delete a non empty group', () => {
 		// see that the list of groups does not contain the group foo
 		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]')
 			.find('li')
+			.not('.app-navigation-caption')
 			.should('not.exist')
 		// and also not in database
 		cy.runOccCommand('group:list --output=json').then(($response) => {
@@ -260,16 +262,16 @@ describe('Settings: Sort groups in the UI', () => {
 
 	it('See that the groups are sorted by the member count', () => {
 		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
-			cy.get('li').eq(0).should('contain', 'B') // 1 member
-			cy.get('li').eq(1).should('contain', 'A') // 0 members
+			cy.get('li').not('.app-navigation-caption').eq(0).should('contain', 'B') // 1 member
+			cy.get('li').not('.app-navigation-caption').eq(1).should('contain', 'A') // 0 members
 		})
 	})
 
 	it('See that the order is preserved after a reload', () => {
 		cy.reload()
 		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
-			cy.get('li').eq(0).should('contain', 'B') // 1 member
-			cy.get('li').eq(1).should('contain', 'A') // 0 members
+			cy.get('li').not('.app-navigation-caption').eq(0).should('contain', 'B') // 1 member
+			cy.get('li').not('.app-navigation-caption').eq(1).should('contain', 'A') // 0 members
 		})
 	})
 
@@ -288,16 +290,16 @@ describe('Settings: Sort groups in the UI', () => {
 
 	it('See that the groups are sorted by the user count', () => {
 		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
-			cy.get('li').eq(0).should('contain', 'A')
-			cy.get('li').eq(1).should('contain', 'B')
+			cy.get('li').not('.app-navigation-caption').eq(0).should('contain', 'A')
+			cy.get('li').not('.app-navigation-caption').eq(1).should('contain', 'B')
 		})
 	})
 
 	it('See that the order is preserved after a reload', () => {
 		cy.reload()
 		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
-			cy.get('li').eq(0).should('contain', 'A')
-			cy.get('li').eq(1).should('contain', 'B')
+			cy.get('li').not('.app-navigation-caption').eq(0).should('contain', 'A')
+			cy.get('li').not('.app-navigation-caption').eq(1).should('contain', 'B')
 		})
 	})
 })