Merge pull request #62053 from nextcloud/backport/61957/stable33

[stable33] perf(carddav): reduce disk usage of photocache

Author: ChristophWurst

apps/dav/lib/CardDAV/PhotoCache.php

@@ -24,6 +24,9 @@
 class PhotoCache {
 	private ?IAppData $photoCacheAppData = null;
 
+	/** Maximum edge length (in pixels) for photos */
+	private const MAX_SIZE = 2048;
+
 	/** @var array */
 	public const ALLOWED_CONTENT_TYPES = [
 		'image/png' => 'png',
@@ -98,6 +101,9 @@ private function hasPhoto(ISimpleFolder $folder): bool {
 	private function getFile(ISimpleFolder $folder, $size): ISimpleFile {
 		$ext = $this->getExtension($folder);
 
+		// cap the size
+		$size = (int)min($size, self::MAX_SIZE);
+
 		if ($size === -1) {
 			$path = 'photo.' . $ext;
 		} else {
@@ -122,9 +128,10 @@ private function getFile(ISimpleFolder $folder, $size): ISimpleFile {
 			}
 
 			$size = (int)($size * $ratio);
-			if ($size !== -1) {
-				$photo->resize($size);
-			}
+			// cap the size
+			$size = min($size, self::MAX_SIZE);
+
+			$photo->resize($size);
 
 			try {
 				$file = $folder->newFile($path);