Skip to content

Commit 47923b9

Browse files
Antreesynickvergessen
authored andcommitted
style(user_status): adjust status modal styles
- remove modal name - propagate box-sizing - reduce gap between sections 12px -> 8px - align icons vertically - add hover effect to status labels Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
1 parent 56174f7 commit 47923b9

6 files changed

Lines changed: 55 additions & 39 deletions

File tree

apps/user_status/src/components/ClearAtSelect.vue

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
:value="option"
1515
:clearable="false"
1616
placement="top"
17+
label-outside
1718
@option:selected="select" />
1819
</div>
1920
</template>
@@ -72,12 +73,9 @@ export default {
7273
<style lang="scss" scoped>
7374
.clear-at-select {
7475
display: flex;
75-
margin-bottom: 10px;
76+
gap: calc(2 * var(--default-grid-baseline));
7677
align-items: center;
77-
78-
&__label {
79-
margin-inline-end: 12px;
80-
}
78+
margin-block: 0 calc(2 * var(--default-grid-baseline));
8179
8280
&__select {
8381
flex-grow: 1;

apps/user_status/src/components/OnlineStatusSelect.vue

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
name="user-status-online"
1212
@change="onChange">
1313
<label :for="id" class="user-status-online-select__label">
14-
{{ label }}
1514
<NcUserStatusIcon :status="type"
15+
class="user-status-online-select__icon"
1616
aria-hidden="true" />
17+
{{ label }}
1718
<em class="user-status-online-select__subline">{{ subline }}</em>
1819
</label>
1920
</div>
@@ -63,45 +64,42 @@ export default {
6364
</script>
6465

6566
<style lang="scss" scoped>
66-
@use 'sass:math';
67-
$icon-size: 24px;
68-
$label-padding: 8px;
69-
7067
.user-status-online-select {
7168
&__label {
72-
position: relative;
73-
display: block;
74-
margin: $label-padding;
75-
padding: $label-padding;
76-
padding-inline-start: $icon-size + $label-padding * 2;
77-
border: 2px solid var(--color-main-background);
69+
box-sizing: inherit;
70+
display: grid;
71+
grid-template-columns: var(--default-clickable-area) 1fr 2fr;
72+
align-items: center;
73+
gap: var(--default-grid-baseline);
74+
min-height: var(--default-clickable-area);
75+
padding: var(--default-grid-baseline);
7876
border-radius: var(--border-radius-large);
7977
background-color: var(--color-background-hover);
80-
background-position: $label-padding center;
81-
background-size: $icon-size;
8278
83-
span,
84-
& {
79+
&, & * {
8580
cursor: pointer;
8681
}
8782
88-
span {
89-
position: absolute;
90-
top: calc(50% - 10px);
91-
inset-inline-start: 10px;
92-
display: block;
93-
width: $icon-size;
94-
height: $icon-size;
83+
&:hover {
84+
background-color: var(--color-background-dark);
9585
}
9686
}
9787
88+
&__icon {
89+
flex-shrink: 0;
90+
max-width: 34px;
91+
max-height: 100%;
92+
}
93+
9894
&__input:checked + &__label {
9995
outline: 2px solid var(--color-main-text);
96+
background-color: var(--color-background-dark);
10097
box-shadow: 0 0 0 4px var(--color-main-background);
10198
}
10299
103100
&__input:focus-visible + &__label {
104101
outline: 2px solid var(--color-primary-element) !important;
102+
background-color: var(--color-background-dark);
105103
}
106104
107105
&__subline {

apps/user_status/src/components/PredefinedStatus.vue

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,19 @@ export default {
8181
flex-basis: 100%;
8282
border-radius: var(--border-radius);
8383
align-items: center;
84-
min-height: 44px;
84+
min-height: var(--default-clickable-area);
85+
padding-inline: var(--default-grid-baseline);
86+
87+
&, & * {
88+
cursor: pointer;
89+
}
90+
91+
&:hover {
92+
background-color: var(--color-background-dark);
93+
}
8594
8695
&--icon {
87-
flex-basis: 40px;
96+
flex-basis: var(--default-clickable-area);
8897
text-align: center;
8998
}
9099
@@ -106,11 +115,13 @@ export default {
106115
&__label:active {
107116
outline: 2px solid var(--color-main-text);
108117
box-shadow: 0 0 0 4px var(--color-main-background);
118+
background-color: var(--color-background-dark);
109119
border-radius: var(--border-radius-large);
110120
}
111121
112122
&__input:focus-visible + &__label {
113123
outline: 2px solid var(--color-primary-element) !important;
124+
background-color: var(--color-background-dark);
114125
border-radius: var(--border-radius-large);
115126
}
116127
}

apps/user_status/src/components/PredefinedStatusesList.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ export default {
7878
.predefined-statuses-list {
7979
display: flex;
8080
flex-direction: column;
81-
margin-bottom: 10px;
81+
gap: var(--default-grid-baseline);
82+
margin-block: 0 calc(2 * var(--default-grid-baseline));
8283
}
8384
</style>

apps/user_status/src/components/PreviousStatus.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ export default {
6565
flex-basis: 100%;
6666
border-radius: var(--border-radius);
6767
align-items: center;
68-
min-height: 44px;
68+
min-height: var(--default-clickable-area);
69+
padding-inline: var(--default-grid-baseline);
6970
7071
&:hover,
7172
&:focus {
@@ -77,7 +78,7 @@ export default {
7778
}
7879
7980
&__icon {
80-
flex-basis: 40px;
81+
flex-basis: var(--default-clickable-area);
8182
text-align: center;
8283
}
8384

apps/user_status/src/components/SetStatusModal.vue

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55

66
<template>
77
<NcModal size="normal"
8-
:name="$t('user_status', 'Set status')"
9-
aria-labelledby="user_status-set-dialog"
8+
label-id="user_status-set-dialog"
9+
dark
1010
:set-return-focus="setReturnFocus"
1111
@close="closeModal">
1212
<div class="set-status-modal">
@@ -336,19 +336,25 @@ export default {
336336
.set-status-modal {
337337
padding: 8px 20px 20px 20px;
338338
339+
&, & * {
340+
box-sizing: border-box;
341+
}
342+
339343
&__header {
340344
font-size: 21px;
341345
text-align: center;
342346
height: fit-content;
343347
min-height: var(--default-clickable-area);
344348
line-height: var(--default-clickable-area);
345349
overflow-wrap: break-word;
346-
margin-block: 0 12px;
350+
margin-block: 0 calc(2 * var(--default-grid-baseline));
347351
}
348352
349353
&__online-status {
350-
display: grid;
351-
grid-template-columns: 1fr 1fr;
354+
display: flex;
355+
flex-direction: column;
356+
gap: calc(2 * var(--default-grid-baseline));
357+
margin-block: 0 calc(2 * var(--default-grid-baseline));
352358
}
353359
354360
&__custom-input {
@@ -357,13 +363,14 @@ export default {
357363
align-items: center;
358364
gap: var(--default-grid-baseline);
359365
width: 100%;
360-
margin-bottom: 10px;
366+
padding-inline-start: var(--default-grid-baseline);
367+
margin-block: 0 calc(2 * var(--default-grid-baseline));
361368
}
362369
363370
&__automation-hint {
364371
display: flex;
365372
width: 100%;
366-
margin-bottom: 10px;
373+
margin-block: 0 calc(2 * var(--default-grid-baseline));
367374
color: var(--color-text-maxcontrast);
368375
}
369376

0 commit comments

Comments
 (0)