Skip to content

Commit 4f1055b

Browse files
authored
Merge pull request #56055 from nextcloud/fix/textarea-overlap
fix(Dav): make absenceform textarea not overlap
2 parents 7426420 + d3a45cf commit 4f1055b

6 files changed

Lines changed: 57 additions & 38 deletions

apps/dav/src/components/AbsenceForm.vue

Lines changed: 43 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@
44
-->
55

66
<template>
7-
<form class="absence" @submit.prevent="saveForm">
8-
<div class="absence__dates">
7+
<form :class="$style.absenceForm" @submit.prevent="saveForm">
8+
<div :class="$style.absenceForm__pickerContainer">
99
<NcDateTimePickerNative
1010
id="absence-first-day"
1111
v-model="firstDay"
12+
:class="$style.absenceForm__picker"
1213
:label="t('dav', 'First day')"
13-
class="absence__dates__picker"
14-
:required="true" />
14+
required />
1515
<NcDateTimePickerNative
1616
id="absence-last-day"
1717
v-model="lastDay"
18+
:class="$style.absenceForm__picker"
1819
:label="t('dav', 'Last day (inclusive)')"
19-
class="absence__dates__picker"
20-
:required="true" />
20+
required />
2121
</div>
2222
<label for="replacement-search-input">{{ t('dav', 'Out of office replacement (optional)') }}</label>
2323
<NcSelectUsers
@@ -28,9 +28,17 @@
2828
:options="options"
2929
@search="asyncFind" />
3030
<NcTextField v-model="status" :label="t('dav', 'Short absence status')" :required="true" />
31-
<NcTextArea v-model="message" :label="t('dav', 'Long absence Message')" :required="true" />
31+
<div :class="$style.absenceForm__longMessageContainer">
32+
<NcTextArea
33+
v-model="message"
34+
:inputClass="$style.absenceForm__longMessage"
35+
:label="t('dav', 'Long absence Message')"
36+
required
37+
resize="none"
38+
rows="6" />
39+
</div>
3240

33-
<div class="absence__buttons">
41+
<div :class="$style.absenceForm__actions">
3442
<NcButton
3543
:disabled="loading || !valid"
3644
variant="primary"
@@ -251,29 +259,40 @@ export default {
251259
}
252260
</script>
253261
254-
<style lang="scss" scoped>
255-
.absence {
262+
<style module>
263+
.absenceForm {
256264
display: flex;
257265
flex-direction: column;
258266
gap: 5px;
267+
}
259268
260-
&__dates {
261-
display: flex;
262-
gap: 10px;
263-
width: 100%;
269+
.absenceForm__pickerContainer {
270+
display: flex;
271+
gap: 10px;
272+
width: 100%;
273+
}
264274
265-
&__picker {
266-
flex: 1 auto;
275+
.absenceForm__picker {
276+
flex: 1 auto;
267277
268-
:deep(.native-datetime-picker--input) {
269-
margin-bottom: 0;
270-
}
271-
}
278+
:global(.native-datetime-picker--input) {
279+
margin-bottom: 0;
272280
}
281+
}
273282
274-
&__buttons {
275-
display: flex;
276-
gap: 5px;
277-
}
283+
.absenceForm__longMessage {
284+
height: calc(var(--default-line-height) * 6 * var(--font-size-small));
285+
}
286+
287+
.absenceForm__longMessageContainer {
288+
height: calc(var(--default-line-height) * 6 * var(--font-size-small) + var(--default-grid-baseline) * 2);
289+
display: flex;
290+
flex-direction: column;
291+
justify-content: start;
292+
}
293+
294+
.absenceForm__actions {
295+
display: flex;
296+
gap: 5px;
278297
}
279298
</style>

dist/dav-dav-settings-personal-availability-BkmjGVZw.chunk.css

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/dav-dav-settings-personal-availability-DSI9XS6G.chunk.css

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/dav-settings-personal-availability.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* extracted by css-entry-points-plugin */
2-
@import './dav-dav-settings-personal-availability-BkmjGVZw.chunk.css';
2+
@import './dav-dav-settings-personal-availability-DSI9XS6G.chunk.css';
33
@import './common-Web-C_oBIsvc.chunk.css';
44
@import './common-ContentCopy-D7mIRwIy.chunk.css';
55
@import './common-ArrowRight-D7L4ZBkR.chunk.css';

dist/dav-settings-personal-availability.mjs

Lines changed: 11 additions & 11 deletions
Large diffs are not rendered by default.

dist/dav-settings-personal-availability.mjs.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)