Merge pull request #57227 from lpcvoid/master

fix: allow `occ maintenance:update:htaccess` to create .htaccess file in case it doesn't exist yet

Author: Altahrim

core/Command/Maintenance/UpdateHtaccess.php

@@ -29,7 +29,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			$output->writeln('.htaccess has been updated');
 			return 0;
 		} else {
-			$output->writeln('<error>Error updating .htaccess file, not enough permissions, not enough free space or "overwrite.cli.url" set to an invalid URL?</error>');
+			$output->writeln('<error>Error updating (or creating) .htaccess file, not enough permissions, not enough free space or "overwrite.cli.url" set to an invalid URL?</error>');
 			return 1;
 		}
 	}

lib/private/Setup.php

@@ -580,6 +580,15 @@ public static function updateHtaccess(): bool {
 
 		$setupHelper = Server::get(Setup::class);
 
+		// Note: The .htaccess file also needs to exist, otherwise `is_writable()`
+		// will return false, even though the file could be written.
+		// This function writes the .htaccess file in that case.
+		if (!file_exists($setupHelper->pathToHtaccess())) {
+			if (!touch($setupHelper->pathToHtaccess())) {
+				return false;
+			}
+		}
+
 		if (!is_writable($setupHelper->pathToHtaccess())) {
 			return false;
 		}