Merge pull request #57921 from nextcloud/fix/snowflake_lock_dir

fix(snowflakes): create file lock files into lock directory

Author: Altahrim

lib/private/Snowflake/FileSequence.php

@@ -33,6 +33,9 @@ public function __construct(
 
 	private function ensureWorkdirExists(): void {
 		if (is_dir($this->workDir)) {
+			if (!is_writable($this->workDir)) {
+				throw new \Exception('File sequence directory exists but is not writable');
+			}
 			return;
 		}
 
@@ -104,6 +107,6 @@ public function nextId(int $serverId, int $seconds, int $milliseconds): int {
 	}
 
 	private function getFilePath(int $fileId): string {
-		return $this->workDir . sprintf(self::LOCK_FILE_FORMAT, $fileId);
+		return $this->workDir . '/' . sprintf(self::LOCK_FILE_FORMAT, $fileId);
 	}
 }

tests/lib/Snowflake/FileSequenceTest.php

@@ -30,6 +30,5 @@ public function tearDown():void {
 		foreach (glob($lockDirectory . '/*') as $file) {
 			unlink($file);
 		}
-		rmdir($lockDirectory);
 	}
 }