Skip to content

Commit 6f2084f

Browse files
committed
chore: Pass correct type for alias in QueryBuilderTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 parent 78336c8 commit 6f2084f

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

tests/lib/DB/QueryBuilder/QueryBuilderTest.php

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,8 @@ public function testFrom(string $table1Name, ?string $table1Alias, ?string $tabl
531531
public static function dataJoin(): array {
532532
return [
533533
[
534-
'd1', 'data2', null, null,
535-
['`d1`' => [['joinType' => 'inner', 'joinTable' => '`*PREFIX*data2`', 'joinAlias' => null, 'joinCondition' => null]]],
534+
'd1', 'data2', '', null,
535+
['`d1`' => [['joinType' => 'inner', 'joinTable' => '`*PREFIX*data2`', 'joinAlias' => '', 'joinCondition' => null]]],
536536
'`*PREFIX*data1` `d1` INNER JOIN `*PREFIX*data2` '
537537
],
538538
[
@@ -611,8 +611,8 @@ public function testInnerJoin($fromAlias, $tableName, $tableAlias, $condition, $
611611
public static function dataLeftJoin(): array {
612612
return [
613613
[
614-
'd1', 'data2', null, null,
615-
['`d1`' => [['joinType' => 'left', 'joinTable' => '`*PREFIX*data2`', 'joinAlias' => null, 'joinCondition' => null]]],
614+
'd1', 'data2', '', null,
615+
['`d1`' => [['joinType' => 'left', 'joinTable' => '`*PREFIX*data2`', 'joinAlias' => '', 'joinCondition' => null]]],
616616
'`*PREFIX*data1` `d1` LEFT JOIN `*PREFIX*data2` '
617617
],
618618
[
@@ -661,8 +661,8 @@ public function testLeftJoin($fromAlias, $tableName, $tableAlias, $condition, $e
661661
public static function dataRightJoin(): array {
662662
return [
663663
[
664-
'd1', 'data2', null, null,
665-
['`d1`' => [['joinType' => 'right', 'joinTable' => '`*PREFIX*data2`', 'joinAlias' => null, 'joinCondition' => null]]],
664+
'd1', 'data2', '', null,
665+
['`d1`' => [['joinType' => 'right', 'joinTable' => '`*PREFIX*data2`', 'joinAlias' => '', 'joinCondition' => null]]],
666666
'`*PREFIX*data1` `d1` RIGHT JOIN `*PREFIX*data2` '
667667
],
668668
[
@@ -678,17 +678,15 @@ public static function dataRightJoin(): array {
678678
];
679679
}
680680

681-
/**
682-
*
683-
* @param string $fromAlias
684-
* @param string $tableName
685-
* @param string $tableAlias
686-
* @param string $condition
687-
* @param array $expectedQueryPart
688-
* @param string $expectedQuery
689-
*/
690681
#[DataProvider('dataRightJoin')]
691-
public function testRightJoin($fromAlias, $tableName, $tableAlias, $condition, $expectedQueryPart, $expectedQuery): void {
682+
public function testRightJoin(
683+
string $fromAlias,
684+
string $tableName,
685+
string $tableAlias,
686+
?string $condition,
687+
array $expectedQueryPart,
688+
string $expectedQuery,
689+
): void {
692690
$this->queryBuilder->from('data1', 'd1');
693691
$this->queryBuilder->rightJoin(
694692
$fromAlias,

0 commit comments

Comments
 (0)