feat(task-streaming): address review comments

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

lib/private/TaskProcessing/Manager.php

@@ -1268,7 +1268,12 @@ public function setTaskProgress(int $id, float $progress): bool {
 	#[\Override]
 	public function setTaskIntermediateOutput(int $id, array $output): bool {
 		// TODO: Not sure if we should rather catch the exceptions of getTask here and fail silently
-		$task = $this->getTask($id);
+		try {
+			$task = $this->getTask($id);
+		} catch (NotFoundException|\OCP\TaskProcessing\Exception\Exception $e) {
+			$this->logger->debug('Couldn\'t find task, not sending intermediate output', ['exception' => $e, 'task_id' => $id]);
+			return false;
+		}
 		if ($task->getStatus() !== Task::STATUS_RUNNING) {
 			return false;
 		}

lib/public/TaskProcessing/IManager.php

@@ -144,7 +144,7 @@ public function setTaskResult(int $id, ?string $error, ?array $result, bool $isU
 
 	/**
 	 * Set the task intermediate output.
-	 * If notify_push is available, the output will be pushed to the user and the task won't be updated in the DB.
+	 * If notify_push is available, the output will be pushed to the user and the task will be updated in the DB every 2 seconds at most.
 	 *
 	 * @param int $id The id of the task
 	 * @param array $output The intermediate output

lib/public/TaskProcessing/SynchronousProviderOptions.php

@@ -11,22 +11,22 @@
  * @since 35.0.0
  */
 class SynchronousProviderOptions {
-	private \Closure $reportOutput;
+	private \Closure $reportIntermediateOutput;
 
 	/**
 	 * @param bool $includeWatermarks Whether to include the watermark in the media output files or not
 	 * @param bool $preferStreaming Whether to prefer streaming the output or not
-	 * @param null|callable $reportOutput Callback for the provider to report the intermediate output (streaming)
+	 * @param null|callable $reportIntermediateOutput Callback for the provider to report the intermediate output (streaming)
 	 * @return void
 	 * @since 35.0.0
 	 */
 	public function __construct(
 		private readonly bool $includeWatermarks = false,
 		private readonly bool $preferStreaming = true,
-		?callable $reportOutput = null,
+		?callable $reportIntermediateOutput = null,
 	) {
-		$this->reportOutput = $reportOutput !== null
-			? \Closure::fromCallable($reportOutput)
+		$this->reportIntermediateOutput = $reportIntermediateOutput !== null
+			? \Closure::fromCallable($reportIntermediateOutput)
 			: static function (array $output): bool {
 				return true;
 			};
@@ -55,7 +55,7 @@ public function getPreferStreaming(): bool {
 	 * @return callable Callback for the provider to report the intermediate output (streaming)
 	 * @since 35.0.0
 	 */
-	public function getReportOutput(): callable {
-		return $this->reportOutput;
+	public function getReportIntermediateOutput(): callable {
+		return $this->reportIntermediateOutput;
 	}
 }