Skip to content

Commit 78cc5e9

Browse files
fix: make unified filter chip accessible
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
1 parent e92c919 commit 78cc5e9

3 files changed

Lines changed: 18 additions & 6 deletions

File tree

core/src/components/UnifiedSearch/SearchFilterChip.vue

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,17 @@
99
<span v-if="pretext.length"> {{ pretext }} : </span>
1010
</span>
1111
<span class="text">{{ text }}</span>
12-
<span class="close-icon" @click="deleteChip">
12+
<button
13+
class="close-icon"
14+
:aria-label="removeAriaLabel"
15+
@click="deleteChip">
1316
<CloseIcon :size="18" />
14-
</span>
17+
</button>
1518
</div>
1619
</template>
1720

1821
<script>
22+
import { t } from '@nextcloud/l10n'
1923
import CloseIcon from 'vue-material-design-icons/Close.vue'
2024
2125
export default {
@@ -36,6 +40,12 @@ export default {
3640
},
3741
},
3842
43+
computed: {
44+
removeAriaLabel() {
45+
return t('core', 'Remove filter: {text}', { text: this.text })
46+
},
47+
},
48+
3949
methods: {
4050
deleteChip() {
4151
this.$emit('delete', this.filter)
@@ -72,7 +82,9 @@ export default {
7282
}
7383
7484
.close-icon {
75-
cursor: pointer ;
85+
background: transparent;
86+
padding: 0;
87+
min-height: 0;
7688
7789
:hover {
7890
filter: invert(20%);

dist/core-unified-search.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-unified-search.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)