Merge pull request #59395 from nextcloud/backport/59330/stable32

[stable32] fix: update email button text to 'Open shared item'

Author: solracsf

apps/sharebymail/lib/ShareByMailProvider.php

@@ -354,7 +354,7 @@ protected function sendEmail(IShare $share, array $emails): void {
 		}
 
 		$emailTemplate->addBodyButton(
-			$this->l->t('Open %s', [$filename]),
+			$this->l->t('Open shared item'),
 			$link
 		);
 
@@ -528,7 +528,7 @@ protected function sendNote(IShare $share): void {
 		$link = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.showShare',
 			['token' => $share->getToken()]);
 		$emailTemplate->addBodyButton(
-			$this->l->t('Open %s', [$filename]),
+			$this->l->t('Open shared item'),
 			$link
 		);
 

apps/sharebymail/tests/ShareByMailProviderTest.php

@@ -1328,7 +1328,7 @@ public function testSendMailNotificationWithSameUserAndUserEmail(): void {
 			->expects($this->once())
 			->method('addBodyButton')
 			->with(
-				'Open file.txt',
+				'Open shared item',
 				'https://example.com/file.txt'
 			);
 		$message
@@ -1450,7 +1450,7 @@ public function testSendMailNotificationWithSameUserAndUserEmailAndNote(): void
 			->expects($this->once())
 			->method('addBodyButton')
 			->with(
-				'Open file.txt',
+				'Open shared item',
 				'https://example.com/file.txt'
 			);
 		$message
@@ -1577,7 +1577,7 @@ public function testSendMailNotificationWithSameUserAndUserEmailAndExpiration():
 			->expects($this->once())
 			->method('addBodyButton')
 			->with(
-				'Open file.txt',
+				'Open shared item',
 				'https://example.com/file.txt'
 			);
 		$message
@@ -1684,7 +1684,7 @@ public function testSendMailNotificationWithDifferentUserAndNoUserEmail(): void
 			->expects($this->once())
 			->method('addBodyButton')
 			->with(
-				'Open file.txt',
+				'Open shared item',
 				'https://example.com/file.txt'
 			);
 		$message
@@ -1781,7 +1781,7 @@ public function testSendMailNotificationWithSameUserAndUserEmailAndReplyToDesact
 			->expects($this->once())
 			->method('addBodyButton')
 			->with(
-				'Open file.txt',
+				'Open shared item',
 				'https://example.com/file.txt'
 			);
 		$message
@@ -1882,7 +1882,7 @@ public function testSendMailNotificationWithDifferentUserAndNoUserEmailAndReplyT
 			->expects($this->once())
 			->method('addBodyButton')
 			->with(
-				'Open file.txt',
+				'Open shared item',
 				'https://example.com/file.txt'
 			);
 		$message