fix(settings): Allow clearing legal and privacy links

nickvergessen · nickvergessen · commit 7c643946171f · 2026-01-07T09:29:34.000+01:00
Signed-off-by: Joas Schilling &lt;coding@schilljs.com&gt;
diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php
@@ -92,7 +92,7 @@ public function updateStylesheet($setting, $value) {
 				if (strlen($value) > 500) {
 					$error = $this->l10n->t('The given legal notice address is too long');
 				}
-				if (!$this->isValidUrl($value)) {
+				if ($value !== '' && !$this->isValidUrl($value)) {
 					$error = $this->l10n->t('The given legal notice address is not a valid URL');
 				}
 				break;
@@ -103,7 +103,7 @@ public function updateStylesheet($setting, $value) {
 				if (strlen($value) > 500) {
 					$error = $this->l10n->t('The given privacy policy address is too long');
 				}
-				if (!$this->isValidUrl($value)) {
+				if ($value !== '' && !$this->isValidUrl($value)) {
 					$error = $this->l10n->t('The given privacy policy address is not a valid URL');
 				}
 				break;

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function updateStylesheet($setting, $value) {`
`92`	`92`	`if (strlen($value) > 500) {`
`93`	`93`	`$error = $this->l10n->t('The given legal notice address is too long');`
`94`	`94`	`}`
`95`		`- if (!$this->isValidUrl($value)) {`
	`95`	`+ if ($value !== '' && !$this->isValidUrl($value)) {`
`96`	`96`	`$error = $this->l10n->t('The given legal notice address is not a valid URL');`
`97`	`97`	`}`
`98`	`98`	`break;`
`@@ -103,7 +103,7 @@ public function updateStylesheet($setting, $value) {`
`103`	`103`	`if (strlen($value) > 500) {`
`104`	`104`	`$error = $this->l10n->t('The given privacy policy address is too long');`
`105`	`105`	`}`
`106`		`- if (!$this->isValidUrl($value)) {`
	`106`	`+ if ($value !== '' && !$this->isValidUrl($value)) {`
`107`	`107`	`$error = $this->l10n->t('The given privacy policy address is not a valid URL');`
`108`	`108`	`}`
`109`	`109`	`break;`