test: mock ocm discovery in external share test

saves ~50s while running tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/files_sharing/lib/External/Storage.php

@@ -62,7 +62,7 @@ public function __construct($options) {
 		$this->manager = $options['manager'];
 		$this->cloudId = $options['cloudId'];
 		$this->logger = Server::get(LoggerInterface::class);
-		$discoveryService = Server::get(IOCMDiscoveryService::class);
+		$discoveryService = $options['discoveryService'] ?? Server::get(IOCMDiscoveryService::class);
 		$this->config = Server::get(IConfig::class);
 		$this->appConfig = Server::get(IAppConfig::class);
 		$this->shareManager = Server::get(IShareManager::class);

apps/files_sharing/tests/ExternalStorageTest.php

@@ -14,6 +14,8 @@
 use OCP\Http\Client\IClientService;
 use OCP\Http\Client\IResponse;
 use OCP\ICertificateManager;
+use OCP\OCM\IOCMDiscoveryService;
+use OCP\OCM\IOCMProvider;
 use OCP\Server;
 
 /**
@@ -61,6 +63,9 @@ private function getTestStorage($uri) {
 		$manager = $this->createMock(ExternalShareManager::class);
 		$client = $this->createMock(IClient::class);
 		$response = $this->createMock(IResponse::class);
+		$discoveryService = $this->createMock(IOCMDiscoveryService::class);
+		$ocmProvider = $this->createMock(IOCMProvider::class);
+
 		$client
 			->expects($this->any())
 			->method('get')
@@ -73,6 +78,12 @@ private function getTestStorage($uri) {
 			->expects($this->any())
 			->method('newClient')
 			->willReturn($client);
+		$discoveryService->method('discover')
+			->willReturn($ocmProvider);
+		$ocmProvider->method('extractProtocolEntry')
+			->willReturn('/public.php/webdav');
+		$ocmProvider->method('getEndPoint')
+			->willReturn($uri);
 
 		return new TestSharingExternalStorage(
 			[
@@ -85,6 +96,7 @@ private function getTestStorage($uri) {
 				'manager' => $manager,
 				'certificateManager' => $certificateManager,
 				'HttpClientService' => $httpClientService,
+				'discoveryService' => $discoveryService,
 			]
 		);
 	}