Skip to content

Commit 7fefbc2

Browse files
XananasX7marcelklehr
authored andcommitted
fix(TaskProcessing): restrict allowed_classes in Manager cache deserialization
The availableTaskTypes cache stores serialized arrays containing ShapeDescriptor objects, ShapeEnumValue objects, and EShapeType enum values. The unserialize() call did not restrict which classes could be instantiated. Restrict deserialization to the three known types: - OCP\TaskProcessing\ShapeDescriptor - OCP\TaskProcessing\ShapeEnumValue - OCP\TaskProcessing\EShapeType This prevents PHP Object Injection if an attacker gains write access to the distributed cache backend. Signed-off-by: El Mehdi Abenhazou <mehdiananas007@gmail.com>
1 parent d0cce3d commit 7fefbc2

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

lib/private/TaskProcessing/Manager.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1828,3 +1828,4 @@ private function runWebhook(Task $task): void {
18281828
}
18291829
}
18301830
}
1831+

0 commit comments

Comments
 (0)