Skip to content

Commit 8041ea3

Browse files
fix: make unified filter chip accessible
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
1 parent 48f579b commit 8041ea3

17 files changed

Lines changed: 35 additions & 105 deletions

core/src/components/UnifiedSearch/SearchFilterChip.vue

Lines changed: 0 additions & 82 deletions
This file was deleted.

core/src/components/UnifiedSearch/UnifiedSearchModal.vue

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@
108108
</NcCheckboxRadioSwitch>
109109
</div>
110110
<div class="unified-search-modal__filters-applied">
111-
<FilterChip
111+
<NcChip
112112
v-for="filter in filters"
113113
:key="filter.id"
114114
:text="filter.name ?? filter.text"
115-
pretext=""
116-
@delete="removeFilter(filter)">
115+
:aria-label-close="t('core', 'Remove filter: {text}', { text: filter.name ?? filter.text })"
116+
@close="removeFilter(filter)">
117117
<template #icon>
118118
<NcAvatar
119119
v-if="filter.type === 'person'"
@@ -123,9 +123,13 @@
123123
hideUserStatus
124124
:hideFavorite="false" />
125125
<IconCalendarRange v-else-if="filter.type === 'date'" />
126-
<img v-else :src="filter.icon" alt="">
126+
<img
127+
v-else
128+
:src="filter.icon"
129+
class="unified-search-modal__filter-icon"
130+
alt="">
127131
</template>
128-
</FilterChip>
132+
</NcChip>
129133
</div>
130134
</div>
131135

@@ -222,6 +226,7 @@ import NcActions from '@nextcloud/vue/components/NcActions'
222226
import NcAvatar from '@nextcloud/vue/components/NcAvatar'
223227
import NcButton from '@nextcloud/vue/components/NcButton'
224228
import NcCheckboxRadioSwitch from '@nextcloud/vue/components/NcCheckboxRadioSwitch'
229+
import NcChip from '@nextcloud/vue/components/NcChip'
225230
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
226231
import NcTextField from '@nextcloud/vue/components/NcTextField'
227232
import IconAccountGroup from 'vue-material-design-icons/AccountGroupOutline.vue'
@@ -234,7 +239,6 @@ import IconListBox from 'vue-material-design-icons/ListBox.vue'
234239
import IconMagnify from 'vue-material-design-icons/Magnify.vue'
235240
import CustomDateRangeModal from './CustomDateRangeModal.vue'
236241
import SearchableList from './SearchableList.vue'
237-
import FilterChip from './SearchFilterChip.vue'
238242
import SearchResult from './SearchResult.vue'
239243
import { useUnifiedSearch } from '../../composables/useUnifiedSearch.ts'
240244
import { unifiedSearchLogger } from '../../logger.js'
@@ -254,11 +258,11 @@ export default defineComponent({
254258
IconMagnify,
255259
256260
CustomDateRangeModal,
257-
FilterChip,
258261
NcActions,
259262
NcActionButton,
260263
NcAvatar,
261264
NcButton,
265+
NcChip,
262266
NcEmptyContent,
263267
NcCheckboxRadioSwitch,
264268
NcTextField,
@@ -1113,6 +1117,14 @@ export default defineComponent({
11131117
padding-top: 4px;
11141118
display: flex;
11151119
flex-wrap: wrap;
1120+
gap: var(--default-grid-baseline);
1121+
}
1122+
1123+
&__filter-icon {
1124+
width: 20px;
1125+
height: 20px;
1126+
object-fit: contain;
1127+
filter: var(--background-invert-if-bright);
11161128
}
11171129
11181130
&__no-content {

dist/1598-1598.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

dist/1598-1598.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/1598-1598.js.map.license

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/6692-6692.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/6692-6692.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/6692-6692.js.map.license

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
6692-6692.js.license

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)