feat(core): load AppMenu as a deferred core script

Register the core/appmenu entry in the user layout so the waffle
launcher mounts like every other core script.

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Author: pringelmann

core/src/appmenu/main.ts

@@ -4,10 +4,6 @@
  *
  * Standalone entry for the waffle launcher (AppMenu). Mounts independently of
  * core-main so the app grid lives in its own chunk.
- *
- * Uses Vue 2 syntax because the legacy webpack pipeline (build/frontend-legacy/)
- * still resolves `vue` to 2.7.16. The modern Vite pipeline ships Vue 3 but does
- * not currently include core; migrating core is out of scope for this work.
  */
 import Vue from 'vue'
 import AppMenu from './AppMenu.vue'
@@ -17,12 +13,14 @@ interface AppMenuInstance {
 }
 
 declare global {
-	// eslint-disable-next-line no-var
 	var OC: {
 		setNavigationCounter?: (id: string, counter: number) => void
 	}
 }
 
+/**
+ * Mount the AppMenu into the header container, if present on this layout.
+ */
 function mount(): void {
 	const container = document.getElementById('header-start__appmenu')
 	if (!container) {
@@ -38,6 +36,4 @@ function mount(): void {
 	}
 }
 
-// Loaded as a deferred core script, so the document is already parsed and the
-// nav container exists by the time this runs.
 mount()

core/src/tests/appmenu/main.spec.ts

@@ -4,10 +4,6 @@
  */
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
-// Match every transitive dependency reachable from AppMenu.vue so its module
-// graph resolves cleanly inside JSDOM. We do NOT mock `vue`: the legacy Vitest
-// config aliases `vue` to Vue 2.7, which matches what the production webpack
-// bundle resolves to. Using the real Vue exercises the actual mount path.
 vi.mock('@nextcloud/initial-state', () => ({
 	loadState: () => [],
 }))
@@ -29,7 +25,6 @@ vi.mock('@nextcloud/router', () => ({
 }))
 
 declare global {
-	// eslint-disable-next-line no-var
 	var OC: { setNavigationCounter?: (id: string, count: number) => void }
 }
 

dist/core-appmenu.js

@@ -0,0 +1,84 @@
+SPDX-License-Identifier: MIT
+SPDX-License-Identifier: ISC
+SPDX-License-Identifier: GPL-3.0-or-later
+SPDX-License-Identifier: AGPL-3.0-or-later
+SPDX-License-Identifier: (MPL-2.0 OR Apache-2.0)
+SPDX-FileCopyrightText: escape-html developers
+SPDX-FileCopyrightText: Tobias Koppers @sokra
+SPDX-FileCopyrightText: Roman Shtylman <shtylman@gmail.com>
+SPDX-FileCopyrightText: Rob Cresswell <robcresswell@pm.me>
+SPDX-FileCopyrightText: Nextcloud GmbH and Nextcloud contributors
+SPDX-FileCopyrightText: Guillaume Chau <guillaume.b.chau@gmail.com>
+SPDX-FileCopyrightText: GitHub Inc.
+SPDX-FileCopyrightText: Evan You
+SPDX-FileCopyrightText: Dr.-Ing. Mario Heiderich, Cure53 <mario@cure53.de> (https://cure53.de/)
+SPDX-FileCopyrightText: David Clark
+
+
+This file is generated from multiple sources. Included packages:
+- @nextcloud/auth
+	- version: 2.6.0
+	- license: GPL-3.0-or-later
+- @nextcloud/browser-storage
+	- version: 0.5.0
+	- license: GPL-3.0-or-later
+- semver
+	- version: 7.7.2
+	- license: ISC
+- @nextcloud/event-bus
+	- version: 3.3.3
+	- license: GPL-3.0-or-later
+- @nextcloud/initial-state
+	- version: 3.0.0
+	- license: GPL-3.0-or-later
+- @nextcloud/l10n
+	- version: 3.4.1
+	- license: GPL-3.0-or-later
+- @nextcloud/logger
+	- version: 3.0.3
+	- license: GPL-3.0-or-later
+- @nextcloud/router
+	- version: 3.1.0
+	- license: GPL-3.0-or-later
+- focus-trap
+	- version: 7.8.0
+	- license: MIT
+- @nextcloud/vue
+	- version: 8.39.0
+	- license: AGPL-3.0-or-later
+- css-loader
+	- version: 7.1.2
+	- license: MIT
+- dompurify
+	- version: 3.4.2
+	- license: (MPL-2.0 OR Apache-2.0)
+- escape-html
+	- version: 1.0.3
+	- license: MIT
+- floating-vue
+	- version: 1.0.0-beta.19
+	- license: MIT
+- process
+	- version: 0.11.10
+	- license: MIT
+- style-loader
+	- version: 4.0.0
+	- license: MIT
+- tabbable
+	- version: 6.4.0
+	- license: MIT
+- vue-loader
+	- version: 15.11.1
+	- license: MIT
+- vue-material-design-icons
+	- version: 5.3.1
+	- license: MIT
+- vue
+	- version: 2.7.16
+	- license: MIT
+- webpack
+	- version: 5.106.2
+	- license: MIT
+- nextcloud
+	- version: 1.0.0
+	- license: AGPL-3.0-or-later

dist/core-appmenu.js.license

@@ -0,0 +1 @@
+core-appmenu.js.license