refactor: Remove isDeleted method

Not used

Signed-off-by: Carl Schwan <carlschwan@kde.org>

Author: CarlSchwan

lib/private/Group/Group.php

@@ -40,7 +40,6 @@ class Group implements IGroup {
 	/** @var User[] */
 	private array $users = [];
 	private bool $usersLoaded = false;
-	private bool $isDeleted = false;
 
 	public function __construct(
 		private string $gid,
@@ -337,7 +336,6 @@ public function delete(): bool {
 				$this->emitter->emit('\OC\Group', 'postDelete', [$this]);
 			}
 		}
-		$this->isDeleted = $result;
 		return $result;
 	}
 
@@ -395,8 +393,4 @@ public function hideFromCollaboration(): bool {
 			return $hide || ($backend instanceof IHideFromCollaborationBackend && $backend->hideGroup($this->gid));
 		}, false);
 	}
-
-	public function isDeleted(): bool {
-		return $this->isDeleted;
-	}
 }

lib/private/Group/LazyGroup.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
@@ -18,7 +20,6 @@
 
 class LazyGroup implements IGroup {
 	private ?IGroup $group = null;
-	private ?bool $isDeleted = null;
 
 	public function __construct(
 		private string $gid,
@@ -34,27 +35,23 @@ public function getGID(): string {
 	private function getGroup(): IGroup {
 		if ($this->group === null) {
 			$this->group = $this->groupManager->get($this->gid);
-			;
 		}
 		if ($this->group === null) {
-			Server::get(LoggerInterface::class)->debug('Trying to use the deleted group: "' . $this->gid . '"', ['app' => 'core']);
-			$this->isDeleted = true;
+			Server::get(LoggerInterface::class)->error('Trying to use the deleted group: "' . $this->gid . '"', ['app' => 'core']);
 			$this->group = new Group($this->gid, [], Server::get(IEventDispatcher::class), Server::get(IUserManager::class));
-		} else {
-			$this->isDeleted = false;
 		}
 		return $this->group;
 	}
 
 	#[\Override]
 	public function getDisplayName(): string {
 		// Use display name cache from IGroupManager
-		return $this->groupManager->getDisplayName($this->gid);
+		return $this->groupManager->getDisplayName($this->gid) ?? $this->gid;
 	}
 
 	#[\Override]
 	public function setDisplayName(string $displayName): bool {
-		return $this->group->setDisplayName($displayName);
+		return $this->getGroup()->setDisplayName($displayName);
 	}
 
 	#[\Override]
@@ -121,12 +118,4 @@ public function canAddUser(): bool {
 	public function hideFromCollaboration(): bool {
 		return $this->getGroup()->hideFromCollaboration();
 	}
-
-	#[\Override]
-	public function isDeleted(): bool {
-		if ($this->isDeleted === null) {
-			$this->getGroup();
-		}
-		return $this->isDeleted === true ? true : $this->getGroup()->isDeleted();
-	}
 }

lib/public/IGroup.php

@@ -148,11 +148,4 @@ public function canAddUser(): bool;
 	 * @since 16.0.0
 	 */
 	public function hideFromCollaboration(): bool;
-
-	/**
-	 * Return whether the group is deleted.
-	 *
-	 * @since 35.0.0
-	 */
-	public function isDeleted(): bool;
 }

tests/lib/Group/ManagerTest.php

@@ -418,30 +418,6 @@ public function testGetUserGroupIds(): void {
 		}
 	}
 
-	public function testGetUserGroupsWithDeletedGroup(): void {
-		$backend = $this->createMock(Database::class);
-		$backend->expects($this->once())
-			->method('getUserGroups')
-			->with('user1')
-			->willReturn(['group1']);
-		$backend->expects($this->any())
-			->method('groupExists')
-			->with('group1')
-			->willReturn(false);
-
-		$manager = new \OC\Group\Manager($this->userManager, $this->dispatcher, $this->logger, $this->cache, $this->remoteIpAddress);
-		$manager->addBackend($backend);
-
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->atLeastOnce())
-			->method('getUID')
-			->willReturn('user1');
-
-		$groups = $manager->getUserGroups($user);
-		$this->assertCount(1, $groups);
-		$this->assertTrue($groups['group1']->isDeleted());
-	}
-
 	public function testInGroup(): void {
 		$backend = $this->getTestBackend();
 		$backend->expects($this->once())