refactor: drop moment from new bundles

On the Vue 3 side lets remove the dependency on Moment as this is a
pretty huge dependency. Instead use plain Intl API for formatting.

This reduces the bundle size by ~1.5MiB.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

apps/files_versions/src/components/VersionEntry.vue

@@ -139,8 +139,7 @@ import type { Version } from '../utils/versions.ts'
 import { getCurrentUser } from '@nextcloud/auth'
 import { formatFileSize, Permission } from '@nextcloud/files'
 import { loadState } from '@nextcloud/initial-state'
-import { t } from '@nextcloud/l10n'
-import moment from '@nextcloud/moment'
+import { getCanonicalLocale, t } from '@nextcloud/l10n'
 import { getRootUrl } from '@nextcloud/router'
 import { computed, nextTick, ref } from 'vue'
 import NcActionButton from '@nextcloud/vue/components/NcActionButton'
@@ -233,7 +232,13 @@ const versionAuthor = computed(() => {
 })
 
 const versionHumanExplicitDate = computed(() => {
-	return moment(props.version.mtime).format('LLLL')
+	return new Date(props.version.mtime).toLocaleString(
+		[getCanonicalLocale(), getCanonicalLocale().split('-')[0]!],
+		{
+			timeStyle: 'long',
+			dateStyle: 'long',
+		},
+	)
 })
 
 const downloadURL = computed(() => {

apps/files_versions/src/utils/versions.ts

@@ -9,7 +9,7 @@ import type { FileStat, ResponseDataDetailed } from 'webdav'
 import { getCurrentUser } from '@nextcloud/auth'
 import axios from '@nextcloud/axios'
 import { getClient } from '@nextcloud/files/dav'
-import moment from '@nextcloud/moment'
+import { getCanonicalLocale } from '@nextcloud/l10n'
 import { encodePath, join } from '@nextcloud/paths'
 import { generateRemoteUrl, generateUrl } from '@nextcloud/router'
 import davRequest from '../utils/davRequest.ts'
@@ -97,7 +97,7 @@ export async function restoreVersion(version: Version) {
  * @param node - The original node
  */
 function formatVersion(version: Required<FileStat>, node: INode): Version {
-	const mtime = moment(version.lastmod).unix() * 1000
+	const mtime = Date.parse(version.lastmod)
 	let previewUrl = ''
 
 	if (mtime === node.mtime?.getTime()) { // Version is the current one
@@ -119,7 +119,13 @@ function formatVersion(version: Required<FileStat>, node: INode): Version {
 		author: version.props['version-author'] ? String(version.props['version-author']) : null,
 		authorName: null,
 		filename: version.filename,
-		basename: moment(mtime).format('LLL'),
+		basename: new Date(mtime).toLocaleString(
+			[getCanonicalLocale(), getCanonicalLocale().split('-')[0]!],
+			{
+				timeStyle: 'long',
+				dateStyle: 'medium',
+			},
+		),
 		mime: version.mime,
 		etag: `${version.props.getetag}`,
 		size: version.size,

apps/user_status/src/services/clearAtService.js

@@ -3,8 +3,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { t } from '@nextcloud/l10n'
-import moment from '@nextcloud/moment'
+import { formatRelativeTime, t } from '@nextcloud/l10n'
 import { dateFactory } from './dateService.js'
 
 /**
@@ -13,7 +12,7 @@ import { dateFactory } from './dateService.js'
  * @param {object | null} clearAt The clear-at config
  * @return {number | null}
  */
-function getTimestampForClearAt(clearAt) {
+export function getTimestampForClearAt(clearAt) {
 	if (clearAt === null) {
 		return null
 	}
@@ -27,8 +26,9 @@ function getTimestampForClearAt(clearAt) {
 	if (clearAt.type === 'end-of') {
 		switch (clearAt.time) {
 			case 'day':
+				return Math.floor(getEndOfDay(date).getTime() / 1000)
 			case 'week':
-				return Number(moment(date).endOf(clearAt.time).format('X'))
+				return Math.floor(getEndOfWeek(date).getTime() / 1000)
 		}
 	}
 	// This is not an officially supported type
@@ -47,7 +47,7 @@ function getTimestampForClearAt(clearAt) {
  * @param {object} clearAt The clearAt object
  * @return {string|null}
  */
-function clearAtFormat(clearAt) {
+export function clearAtFormat(clearAt) {
 	if (clearAt === null) {
 		return t('user_status', 'Don\'t clear')
 	}
@@ -65,23 +65,35 @@ function clearAtFormat(clearAt) {
 	}
 
 	if (clearAt.type === 'period') {
-		return moment.duration(clearAt.time * 1000).humanize()
+		return formatRelativeTime(Date.now() + clearAt.time * 1000)
 	}
 
 	// This is not an officially supported type
 	// but only used internally to show the remaining time
 	// in the Set Status Modal
 	if (clearAt.type === '_time') {
-		const momentNow = moment(dateFactory())
-		const momentClearAt = moment(clearAt.time, 'X')
-
-		return moment.duration(momentNow.diff(momentClearAt)).humanize()
+		return formatRelativeTime(clearAt.time * 1000)
 	}
 
 	return null
 }
 
-export {
-	clearAtFormat,
-	getTimestampForClearAt,
+/**
+ * @param {Date} date - The date to calculate the end of the day for
+ */
+function getEndOfDay(date) {
+	const endOfDay = new Date(date)
+	endOfDay.setHours(23, 59, 59, 999)
+	return endOfDay
+}
+
+/**
+ * Calculates the end of the week for a given date
+ *
+ * @param {Date} date - The date to calculate the end of the week for
+ */
+function getEndOfWeek(date) {
+	const endOfWeek = getEndOfDay(date)
+	endOfWeek.setDate(date.getDate() + ((endOfWeek.getFirstDay() - 1 - endOfWeek.getDay() + 7) % 7))
+	return endOfWeek
 }

package-lock.json

@@ -51,7 +51,6 @@
     "@nextcloud/initial-state": "^3.0.0",
     "@nextcloud/l10n": "^3.4.1",
     "@nextcloud/logger": "^3.0.3",
-    "@nextcloud/moment": "^1.3.5",
     "@nextcloud/password-confirmation": "^6.0.2",
     "@nextcloud/paths": "^3.0.0",
     "@nextcloud/router": "^3.1.0",