Skip to content

Commit 8f9b11e

Browse files
authored
Merge pull request #59748 from nextcloud/chore/remove-handlebars
chore!(core): remove deprecated Handlebars globals
2 parents dfa407c + b993ce9 commit 8f9b11e

10 files changed

Lines changed: 15 additions & 128 deletions

File tree

build/frontend-legacy/package-lock.json

Lines changed: 9 additions & 106 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/frontend-legacy/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
"dompurify": "^3.4.0",
6868
"escape-html": "^1.0.3",
6969
"focus-trap": "^8.0.1",
70-
"handlebars": "^4.7.8",
7170
"is-svg": "^6.1.0",
7271
"libphonenumber-js": "^1.12.41",
7372
"lodash": "^4.18.1",

core/src/OC/l10n.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
translatePlural,
1313
unregister,
1414
} from '@nextcloud/l10n'
15-
import Handlebars from 'handlebars'
1615

1716
/**
1817
* L10N namespace with localization functions.
@@ -84,7 +83,3 @@ const L10n = {
8483
}
8584

8685
export default L10n
87-
88-
Handlebars.registerHelper('t', function(app, text) {
89-
return translate(app, text)
90-
})

core/src/globals.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import ClipboardJS from 'clipboard'
88
import { dav } from 'davclient.js'
9-
import Handlebars from 'handlebars'
109
import moment from 'moment'
1110
import _ from 'underscore'
1211
import { initCore } from './init.js'
@@ -52,7 +51,6 @@ function setDeprecatedProp(global, cb, msg) {
5251
setDeprecatedProp(['_'], () => _, 'The global underscore is deprecated. It will be removed in a later versions without another warning. Please ship your own.')
5352
setDeprecatedProp(['Clipboard', 'ClipboardJS'], () => ClipboardJS, 'please ship your own, this will be removed in Nextcloud 20')
5453
setDeprecatedProp(['dav'], () => dav, 'please ship your own. It will be removed in a later versions without another warning. Please ship your own.')
55-
setDeprecatedProp('Handlebars', () => Handlebars, 'please ship your own, this will be removed in Nextcloud 20')
5654
setDeprecatedProp('moment', () => moment, 'please ship your own, this will be removed in Nextcloud 20')
5755

5856
window.OC = OC

dist/core-login.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-login.js.license

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ SPDX-FileCopyrightText: hookable developers
1414
SPDX-FileCopyrightText: escape-html developers
1515
SPDX-FileCopyrightText: debounce developers
1616
SPDX-FileCopyrightText: atomiks
17-
SPDX-FileCopyrightText: Yehuda Katz
1817
SPDX-FileCopyrightText: Varun A P
1918
SPDX-FileCopyrightText: Tobias Koppers @sokra
2019
SPDX-FileCopyrightText: T. Jameson Little <t.jameson.little@gmail.com>
@@ -222,9 +221,6 @@ This file is generated from multiple sources. Included packages:
222221
- focus-trap
223222
- version: 8.0.1
224223
- license: MIT
225-
- handlebars
226-
- version: 4.7.8
227-
- license: MIT
228224
- hookable
229225
- version: 5.5.3
230226
- license: MIT

dist/core-login.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.license

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ SPDX-FileCopyrightText: escape-html developers
1515
SPDX-FileCopyrightText: debounce developers
1616
SPDX-FileCopyrightText: clipboard developers
1717
SPDX-FileCopyrightText: atomiks
18-
SPDX-FileCopyrightText: Yehuda Katz
1918
SPDX-FileCopyrightText: Varun A P
2019
SPDX-FileCopyrightText: Tobias Koppers @sokra
2120
SPDX-FileCopyrightText: Titus Wormer <tituswormer@gmail.com> (https://wooorm.com)
@@ -254,9 +253,6 @@ This file is generated from multiple sources. Included packages:
254253
- focus-trap
255254
- version: 8.0.1
256255
- license: MIT
257-
- handlebars
258-
- version: 4.7.8
259-
- license: MIT
260256
- hookable
261257
- version: 5.5.3
262258
- license: MIT

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)