Skip to content

Commit 90345dd

Browse files
Merge pull request #38144 from nextcloud/fix/36922-9.1.3.1h/8.1_-_When_editing_a_user_in_the_table,_input_fields_appear_in_the_cells_that_can_be_used_to_edit_the_data
Add hidden labels for inputs while editing user row
2 parents b935725 + da36d19 commit 90345dd

5 files changed

Lines changed: 21 additions & 10 deletions

File tree

apps/settings/src/components/UserList/UserRow.vue

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
<form :class="{'icon-loading-small': loading.displayName}"
7777
class="displayName"
7878
@submit.prevent="updateDisplayName">
79+
<label class="hidden-visually" :for="'displayName'+user.id+rand">{{ t('settings', 'Edit display name') }}</label>
7980
<input :id="'displayName'+user.id+rand"
8081
ref="displayName"
8182
:disabled="loading.displayName||loading.all"
@@ -102,6 +103,7 @@
102103
:class="{'icon-loading-small': loading.password}"
103104
class="password"
104105
@submit.prevent="updatePassword">
106+
<label class="hidden-visually" :for="'password'+user.id+rand">{{ t('settings', 'Add new password') }}</label>
105107
<input :id="'password'+user.id+rand"
106108
ref="password"
107109
:disabled="loading.password || loading.all"
@@ -121,6 +123,7 @@
121123
<form :class="{'icon-loading-small': loading.mailAddress}"
122124
class="mailAddress"
123125
@submit.prevent="updateEmail">
126+
<label class="hidden-visually" :for="'mailAddress'+user.id+rand">{{ t('settings', 'Add new email address') }}</label>
124127
<input :id="'mailAddress'+user.id+rand"
125128
ref="mailAddress"
126129
:disabled="loading.mailAddress||loading.all"
@@ -134,7 +137,9 @@
134137
<input class="icon-confirm" type="submit" value="">
135138
</form>
136139
<div :class="{'icon-loading-small': loading.groups}" class="groups">
137-
<NcMultiselect :close-on-select="false"
140+
<label class="hidden-visually" :for="'groups'+user.id+rand">{{ t('settings', 'Add user to group') }}</label>
141+
<NcMultiselect :id="'groups'+user.id+rand"
142+
:close-on-select="false"
138143
:disabled="loading.groups||loading.all"
139144
:limit="2"
140145
:multiple="true"
@@ -156,7 +161,9 @@
156161
<div v-if="subAdminsGroups.length>0 && settings.isAdmin"
157162
:class="{'icon-loading-small': loading.subadmins}"
158163
class="subadmins">
159-
<NcMultiselect :close-on-select="false"
164+
<label class="hidden-visually" :for="'subadmins'+user.id+rand">{{ t('settings', 'Set user as admin for') }}</label>
165+
<NcMultiselect :id="'subadmins'+user.id+rand"
166+
:close-on-select="false"
160167
:disabled="loading.subadmins||loading.all"
161168
:limit="2"
162169
:multiple="true"
@@ -175,7 +182,9 @@
175182
<div :title="usedSpace"
176183
:class="{'icon-loading-small': loading.quota}"
177184
class="quota">
178-
<NcMultiselect :allow-empty="false"
185+
<label class="hidden-visually" :for="'quota'+user.id+rand">{{ t('settings', 'Select user quota') }}</label>
186+
<NcMultiselect :id="'quota'+user.id+rand"
187+
:allow-empty="false"
179188
:disabled="loading.quota||loading.all"
180189
:options="quotaOptions"
181190
:placeholder="t('settings', 'Select user quota')"
@@ -191,7 +200,9 @@
191200
<div v-if="showConfig.showLanguages"
192201
:class="{'icon-loading-small': loading.languages}"
193202
class="languages">
194-
<NcMultiselect :allow-empty="false"
203+
<label class="hidden-visually" :for="'language'+user.id+rand">{{ t('settings', 'Set the language') }}</label>
204+
<NcMultiselect :id="'language'+user.id+rand"
205+
:allow-empty="false"
195206
:disabled="loading.languages||loading.all"
196207
:options="languages"
197208
:placeholder="t('settings', 'No language set')"

dist/settings-users-8351.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-users-8351.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)