fix: check share target parent in userfolders mount

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/files_sharing/lib/ShareTargetValidator.php

@@ -9,12 +9,11 @@
 namespace OCA\Files_Sharing;
 
 use OC\Files\Filesystem;
-use OC\Files\SetupManager;
 use OC\Files\View;
 use OCP\Cache\CappedMemoryCache;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Files\Config\ICachedMountInfo;
-use OCP\Files\Mount\IMountManager;
+use OCP\Files\IRootFolder;
 use OCP\Files\Mount\IMountPoint;
 use OCP\IUser;
 use OCP\Share\Events\VerifyMountPointEvent;
@@ -30,8 +29,7 @@ class ShareTargetValidator {
 	public function __construct(
 		private readonly IManager $shareManager,
 		private readonly IEventDispatcher $eventDispatcher,
-		private readonly SetupManager $setupManager,
-		private readonly IMountManager $mountManager,
+		private readonly IRootFolder $rootFolder,
 	) {
 		$this->folderExistsCache = new CappedMemoryCache();
 	}
@@ -67,8 +65,10 @@ public function verifyMountPoint(
 
 		/** @psalm-suppress InternalMethod */
 		$absoluteParent = $recipientView->getAbsolutePath($parent);
-		$this->setupManager->setupForPath($absoluteParent);
-		$parentMount = $this->mountManager->find($absoluteParent);
+
+		// the share target always has to be in the users home
+		$userFolder = $this->rootFolder->getUserFolder($user->getUID());
+		$parentMount = $userFolder->getMountPoint();
 
 		$cached = $this->folderExistsCache->get($parent);
 		if ($cached !== null) {

apps/files_sharing/tests/ShareTargetValidatorTest.php

@@ -9,12 +9,11 @@
 namespace OCA\Files_Sharing\Tests;
 
 use OC\EventDispatcher\EventDispatcher;
-use OC\Files\SetupManager;
 use OCA\Files_Sharing\ShareTargetValidator;
 use OCP\Constants;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Files\Config\ICachedMountInfo;
-use OCP\Files\Mount\IMountManager;
+use OCP\Files\IRootFolder;
 use OCP\IUser;
 use OCP\Server;
 use OCP\Share\Events\VerifyMountPointEvent;
@@ -57,8 +56,7 @@ protected function setUp(): void {
 		$this->targetValidator = new ShareTargetValidator(
 			Server::get(IManager::class),
 			$this->eventDispatcher,
-			Server::get(SetupManager::class),
-			Server::get(IMountManager::class),
+			Server::get(IRootFolder::class),
 		);
 		$this->user2 = $this->createMock(IUser::class);
 		$this->user2->method('getUID')