perf: Optimize deleting the list of invalid shares

And make the code a bit easier to read.

Signed-off-by: Carl Schwan <carlschwan@kde.org>

Author: CarlSchwan

lib/private/Repair/RepairInvalidShares.php

@@ -8,6 +8,7 @@
 namespace OC\Repair;
 
 use OCP\Constants;
+use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\IConfig;
 use OCP\IDBConnection;
 use OCP\Migration\IOutput;
@@ -67,19 +68,21 @@ private function removeSharesNonExistingParent(IOutput $output): void {
 
 		$deleteQuery = $this->connection->getQueryBuilder();
 		$deleteQuery->delete('share')
-			->where($deleteQuery->expr()->eq('parent', $deleteQuery->createParameter('parent')));
+			->where($deleteQuery->expr()->in('parent', $deleteQuery->createParameter('parent')));
 
-		$deletedInLastChunk = self::CHUNK_SIZE;
-		while ($deletedInLastChunk === self::CHUNK_SIZE) {
-			$deletedInLastChunk = 0;
+		do {
 			$result = $query->executeQuery();
-			while ($row = $result->fetch()) {
-				$deletedInLastChunk++;
-				$deletedEntries += $deleteQuery->setParameter('parent', (int)$row['parent'])
-					->executeStatement();
-			}
+			$parents = $result->fetchFirstColumn();
 			$result->closeCursor();
-		}
+
+			if ($parents === []) {
+				break;
+			}
+
+			$deletedInLastChunk = $deleteQuery->setParameter('parent', $parents, IQueryBuilder::PARAM_INT_ARRAY)
+				->executeStatement();
+			$deletedEntries += $deletedInLastChunk;
+		} while ($deletedInLastChunk === self::CHUNK_SIZE);
 
 		if ($deletedEntries) {
 			$output->info('Removed ' . $deletedEntries . ' shares where the parent did not exist');