fix(appstore): only show appstore entries if actual from appstore

- resolves #61273

Shipped apps are no longer published to the appstore,
so the appstore data is outdated and confusing.
So ignore them from the app fetcher and only use the local data.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

apps/appstore/lib/Controller/ApiController.php

@@ -330,7 +330,14 @@ private function fetchApps(): void {
 
 		$apps = $this->getAppsForCategory('');
 		$supportedApps = $this->subscriptionRegistry->delegateGetSupportedApps();
+		$shippedApps = $this->appManager->getAlwaysEnabledApps();
 		foreach ($apps as $app) {
+			if (in_array($app['id'], $shippedApps)) {
+				// shipped apps are no longer published on the appstore
+				// so skip them to avoid confusion with outdated data
+				continue;
+			}
+
 			$app['appstore'] = true;
 			if (!array_key_exists($app['id'], $this->allApps)) {
 				$this->allApps[$app['id']] = $app;