Skip to content

Commit 9fca0da

Browse files
fix: make unified filter chip accessible
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
1 parent 6b2ce7b commit 9fca0da

19 files changed

Lines changed: 125 additions & 105 deletions

core/src/components/UnifiedSearch/SearchFilterChip.vue

Lines changed: 0 additions & 82 deletions
This file was deleted.

core/src/components/UnifiedSearch/UnifiedSearchModal.vue

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,12 @@
113113
</NcCheckboxRadioSwitch>
114114
</div>
115115
<div class="unified-search-modal__filters-applied">
116-
<FilterChip
116+
<NcChip
117117
v-for="filter in filters"
118118
:key="filter.id"
119119
:text="filter.name ?? filter.text"
120-
pretext=""
121-
@delete="removeFilter(filter)">
120+
:aria-label-close="t('core', 'Remove filter: {text}', { text: filter.name ?? filter.text })"
121+
@close="removeFilter(filter)">
122122
<template #icon>
123123
<NcAvatar
124124
v-if="filter.type === 'person'"
@@ -128,9 +128,13 @@
128128
hideUserStatus
129129
:hideFavorite="false" />
130130
<IconCalendarRange v-else-if="filter.type === 'date'" />
131-
<img v-else :src="filter.icon" alt="">
131+
<img
132+
v-else
133+
:src="filter.icon"
134+
class="unified-search-modal__filter-icon"
135+
alt="">
132136
</template>
133-
</FilterChip>
137+
</NcChip>
134138
</div>
135139
</div>
136140

@@ -233,6 +237,7 @@ import NcActions from '@nextcloud/vue/components/NcActions'
233237
import NcAvatar from '@nextcloud/vue/components/NcAvatar'
234238
import NcButton from '@nextcloud/vue/components/NcButton'
235239
import NcCheckboxRadioSwitch from '@nextcloud/vue/components/NcCheckboxRadioSwitch'
240+
import NcChip from '@nextcloud/vue/components/NcChip'
236241
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
237242
import NcTextField from '@nextcloud/vue/components/NcTextField'
238243
import IconAccountGroup from 'vue-material-design-icons/AccountGroupOutline.vue'
@@ -245,7 +250,6 @@ import IconListBox from 'vue-material-design-icons/ListBox.vue'
245250
import IconMagnify from 'vue-material-design-icons/Magnify.vue'
246251
import CustomDateRangeModal from './CustomDateRangeModal.vue'
247252
import SearchableList from './SearchableList.vue'
248-
import FilterChip from './SearchFilterChip.vue'
249253
import SearchResult from './SearchResult.vue'
250254
import { useUnifiedSearch } from '../../composables/useUnifiedSearch.ts'
251255
import { unifiedSearchLogger } from '../../logger.js'
@@ -271,11 +275,11 @@ export default defineComponent({
271275
IconMagnify,
272276
273277
CustomDateRangeModal,
274-
FilterChip,
275278
NcActions,
276279
NcActionButton,
277280
NcAvatar,
278281
NcButton,
282+
NcChip,
279283
NcEmptyContent,
280284
NcCheckboxRadioSwitch,
281285
NcTextField,
@@ -1299,6 +1303,14 @@ export default defineComponent({
12991303
padding-top: 4px;
13001304
display: flex;
13011305
flex-wrap: wrap;
1306+
gap: var(--default-grid-baseline);
1307+
}
1308+
1309+
&__filter-icon {
1310+
width: 20px;
1311+
height: 20px;
1312+
object-fit: contain;
1313+
filter: var(--background-invert-if-bright);
13021314
}
13031315
13041316
&__no-content {

dist/1598-1598.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

dist/1598-1598.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/1598-1598.js.map.license

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/6692-6692.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/6692-6692.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/6692-6692.js.map.license

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
6692-6692.js.license

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)