Merge pull request #59777 from nextcloud/backport/59757/stable29

artonge · web-flow · commit a0b5986a3477 · 2026-04-21T15:02:11.000+02:00
[stable29] fix(oauth2): Add missing urlencode for failure redirection
diff --git a/apps/oauth2/lib/Controller/LoginRedirectorController.php b/apps/oauth2/lib/Controller/LoginRedirectorController.php
@@ -106,7 +106,7 @@ public function authorize($client_id,
 
 		if ($response_type !== 'code') {
 			//Fail
-			$url = $client->getRedirectUri() . '?error=unsupported_response_type&state=' . $state;
+			$url = $client->getRedirectUri() . '?error=unsupported_response_type&state=' . \urlencode($state);
 			return new RedirectResponse($url);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public function authorize($client_id,`
`106`	`106`
`107`	`107`	`if ($response_type !== 'code') {`
`108`	`108`	`//Fail`
`109`		`- $url = $client->getRedirectUri() . '?error=unsupported_response_type&state=' . $state;`
	`109`	`+ $url = $client->getRedirectUri() . '?error=unsupported_response_type&state=' . \urlencode($state);`
`110`	`110`	`return new RedirectResponse($url);`
`111`	`111`	`}`
`112`	`112`