Skip to content

Commit a17ee2b

Browse files
authored
Merge pull request #58141 from nextcloud/backport/58059/stable31
2 parents 1d5e0c6 + ec8ef13 commit a17ee2b

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

core/Controller/LoginController.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,9 @@ public function __construct(
7777
#[FrontpageRoute(verb: 'GET', url: '/logout')]
7878
public function logout() {
7979
$loginToken = $this->request->getCookie('nc_token');
80-
if (!is_null($loginToken)) {
81-
$this->config->deleteUserValue($this->userSession->getUser()->getUID(), 'login_token', $loginToken);
80+
$uid = $this->userSession->getUser()?->getUID();
81+
if ($loginToken !== null && $uid !== null) {
82+
$this->config->deleteUserValue($uid, 'login_token', $loginToken);
8283
}
8384
$this->userSession->logout();
8485

@@ -97,6 +98,10 @@ public function logout() {
9798
$response->addHeader('Clear-Site-Data', '"cache", "storage"');
9899
}
99100

101+
if ($uid !== null) {
102+
$response->addHeader('X-User-Id', $uid);
103+
}
104+
100105
return $response;
101106
}
102107

tests/Core/Controller/LoginControllerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ public function testLogoutWithToken(): void {
217217

218218
$expected = new RedirectResponse('/login');
219219
$expected->addHeader('Clear-Site-Data', '"cache", "storage"');
220+
$expected->addHeader('X-User-Id', 'JohnDoe');
220221
$this->assertEquals($expected, $this->loginController->logout());
221222
}
222223

0 commit comments

Comments
 (0)