fix(cypress): use atomic selectors to avoid stale DOM in action menu queries

getActionEntryForFile/Id chained .find() off a cy.get() result inside a
.then() callback. After the actions button click triggers a Vue re-render,
the stored element reference goes stale before .find() executes, causing
intermittent "subject no longer attached to DOM" failures in files-sidebar,
public-share/download, and version_naming specs.

Collapse the two-step get+find into a single combined CSS selector so
Cypress retries the whole query atomically on re-render. Same fix applied
to the alias-then-find pattern in version_naming.cy.ts.

Signed-off-by: Anna Larch <anna@larch.dev>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>

Author: Anna Larch

cypress/e2e/files/FilesUtils.ts

@@ -26,9 +26,7 @@ export const getActionButtonForFile = (filename: string) => getActionsForFile(fi
 export function getActionEntryForFileId(fileid: number, actionId: string) {
 	return getActionButtonForFileId(fileid)
 		.should('have.attr', 'aria-controls')
-		.then((menuId) => cy.get(`#${menuId}`)
-			.should('exist')
-			.find(`[data-cy-files-list-row-action="${CSS.escape(actionId)}"]`))
+		.then((menuId) => cy.get(`#${menuId} [data-cy-files-list-row-action="${CSS.escape(actionId)}"]`))
 }
 
 /**
@@ -39,9 +37,7 @@ export function getActionEntryForFileId(fileid: number, actionId: string) {
 export function getActionEntryForFile(file: string, actionId: string) {
 	return getActionButtonForFile(file)
 		.should('have.attr', 'aria-controls')
-		.then((menuId) => cy.get(`#${menuId}`)
-			.should('exist')
-			.find(`[data-cy-files-list-row-action="${CSS.escape(actionId)}"]`))
+		.then((menuId) => cy.get(`#${menuId} [data-cy-files-list-row-action="${CSS.escape(actionId)}"]`))
 }
 
 /**

cypress/e2e/files_versions/version_naming.cy.ts

@@ -76,14 +76,10 @@ describe('Versions naming', () => {
 		navigateToFolder('share')
 		openVersionsPanel(randomFileName)
 
-		cy.get('[data-files-versions-version]')
-			.eq(0)
-			.as('firstVersion')
-			.find('.action-item__menutoggle')
-			.should('not.exist')
-		cy.get('@firstVersion')
-			.find('[data-cy-version-action="label"]')
-			.should('not.exist')
+		cy.get('[data-files-versions-version]').eq(0).within(() => {
+			cy.get('.action-item__menutoggle').should('not.exist')
+			cy.get('[data-cy-version-action="label"]').should('not.exist')
+		})
 
 		doesNotHaveAction(1, 'label')
 		doesNotHaveAction(2, 'label')