fixup!: try to handle uncached folders

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Author: Antreesy

apps/files_external/lib/Lib/Storage/AmazonS3.php

@@ -672,6 +672,15 @@ private function getDirectoryMetaData(string $path): ?array {
 		if ($cacheEntry instanceof CacheEntry) {
 			return $cacheEntry->getData();
 		} else {
+			$directoryMarker = $path === '.' ? false : $this->headObject($path . '/');
+			if ($directoryMarker !== false) {
+				$data = $this->objectToMetaData($directoryMarker);
+				$data['mimetype'] = FileInfo::MIMETYPE_FOLDER;
+				$data['permissions'] = Constants::PERMISSION_ALL;
+				$data['size'] = -1;
+				return $data;
+			}
+
 			return [
 				'name' => basename($path),
 				'mimetype' => FileInfo::MIMETYPE_FOLDER,

apps/files_external/tests/Storage/Amazons3Test.php

@@ -64,6 +64,31 @@ public function testStatRootPreservesStorageMtimeFromCache(): void {
 		);
 	}
 
+	/**
+	 * Regression test for uncached S3 folders with a real directory marker object.
+	 *
+	 * mkdir() creates a `<path>/` object in S3. Before the fix, getDirectoryMetaData()
+	 * ignored that marker on a cache miss and returned time(), so simply reading the
+	 * folder could stamp it as "few seconds ago". stat() must use the marker metadata
+	 * instead, which stays stable across repeated reads.
+	 */
+	public function testStatDirectoryMarkerPreservesStorageMtimeWithoutCache(): void {
+		$this->instance->mkdir('markerdir');
+
+		$firstStat = $this->instance->stat('markerdir');
+		$this->assertNotFalse($firstStat);
+
+		sleep(2);
+
+		$secondStat = $this->instance->stat('markerdir');
+		$this->assertNotFalse($secondStat);
+		$this->assertEquals(
+			$firstStat['storage_mtime'],
+			$secondStat['storage_mtime'],
+			'stat() for an uncached S3 directory marker must not synthesize a fresh timestamp on every read'
+		);
+	}
+
 	/**
 	 * Regression test for Common::getMetaData discarding storage_mtime for S3 directories.
 	 *