chore: Fix psalm issues following strong typing of IUser

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Author: come-nc

apps/files_trashbin/lib/Trashbin.php

@@ -850,7 +850,7 @@ private static function calculateFreeSpace(Folder $userFolder, int|float $trashb
 
 		$softQuota = true;
 		$quota = $user->getQuota();
-		if ($quota === null || $quota === 'none') {
+		if ($quota === 'none') {
 			$quota = Filesystem::free_space('/');
 			$softQuota = false;
 			// inf or unknown free space

apps/files_versions/lib/Storage.php

@@ -879,7 +879,7 @@ public static function expire($filename, $uid) {
 
 			$softQuota = true;
 			$quota = $user->getQuota();
-			if ($quota === null || $quota === 'none') {
+			if ($quota === 'none') {
 				$quota = Filesystem::free_space('/');
 				$softQuota = false;
 			} else {

apps/provisioning_api/lib/Controller/GroupsController.php

@@ -216,7 +216,7 @@ public function getGroupUsersDetails(string $groupId, string $search = '', ?int
 			foreach ($users as $user) {
 				try {
 					/** @var IUser $user */
-					$userId = (string)$user->getUID();
+					$userId = $user->getUID();
 					$userData = $this->getUserData($userId);
 					// Do not insert empty entry
 					if ($userData !== null) {

apps/user_ldap/lib/Connection.php

@@ -313,7 +313,7 @@ public function writeToCache($key, $value, ?int $ttlOverride = null): void {
 		$key = $this->getCacheKey($key);
 		$value = base64_encode(json_encode($value));
 		$ttl = $ttlOverride ?? $this->configuration->ldapCacheTTL;
-		$this->cache->set($key, $value, $ttl);
+		$this->cache->set($key, $value, (int)$ttl);
 	}
 
 	public function clearCache() {

build/psalm-baseline.xml

@@ -3417,6 +3417,7 @@
       <code><![CDATA[getPassword]]></code>
       <code><![CDATA[getRemember]]></code>
       <code><![CDATA[getScope]]></code>
+      <code><![CDATA[getToken]]></code>
       <code><![CDATA[setExpires]]></code>
       <code><![CDATA[setLastCheck]]></code>
       <code><![CDATA[setName]]></code>

lib/private/Group/Manager.php

@@ -452,7 +452,7 @@ public function displayNamesInGroup($gid, $search = '', $limit = -1, $offset = 0
 
 		$matchingUsers = [];
 		foreach ($groupUsers as $groupUser) {
-			$matchingUsers[(string)$groupUser->getUID()] = $groupUser->getDisplayName();
+			$matchingUsers[$groupUser->getUID()] = $groupUser->getDisplayName();
 		}
 		return $matchingUsers;
 	}

lib/private/User/LazyUser.php

@@ -148,7 +148,7 @@ public function setEnabled(bool $enabled = true): void {
 	}
 
 	#[\Override]
-	public function getEMailAddress(): string {
+	public function getEMailAddress(): ?string {
 		return $this->getUser()->getEMailAddress();
 	}