fix(accounts): address review feedback — remove $throwOnData from testPropertyScope and fix @SInCE

- Remove the always-true $throwOnData parameter from testPropertyScope; the
  dead else-branches (setScope(LOCAL)) are dropped, all paths now throw directly
- Fix @SInCE annotation on UNPUBLISHED_PROPERTIES to 34.0.0

AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: miaulalala

lib/private/Accounts/AccountManager.php

@@ -115,8 +115,8 @@ protected function testValueLengths(array $properties, bool $throwOnData = false
 		}
 	}
 
-	protected function testPropertyScope(IAccountProperty $property, array $allowedScopes, bool $throwOnData): void {
-		if ($throwOnData && !in_array($property->getScope(), $allowedScopes, true)) {
+	protected function testPropertyScope(IAccountProperty $property, array $allowedScopes): void {
+		if (!in_array($property->getScope(), $allowedScopes, true)) {
 			throw new InvalidArgumentException('scope');
 		}
 
@@ -125,36 +125,23 @@ protected function testPropertyScope(IAccountProperty $property, array $allowedS
 			in_array($property->getName(), self::UNPUBLISHED_PROPERTIES, true)
 			&& in_array($property->getScope(), [self::SCOPE_FEDERATED, self::SCOPE_PUBLISHED], true)
 		) {
-			if ($throwOnData) {
-				throw new InvalidArgumentException('scope');
-			} else {
-				$property->setScope(self::SCOPE_LOCAL);
-			}
+			throw new InvalidArgumentException('scope');
 		}
 
 		// PUBLISHED scope requires the lookup server upload to be enabled by the admin.
 		if ($property->getScope() === self::SCOPE_PUBLISHED) {
 			$lookupServerUploadEnabled = $this->config->getAppValue('files_sharing', 'lookupServerUploadEnabled', 'no') === 'yes';
 			if (!$lookupServerUploadEnabled) {
-				if ($throwOnData) {
-					throw new InvalidArgumentException('scope');
-				} else {
-					$property->setScope(self::SCOPE_LOCAL);
-				}
+				throw new InvalidArgumentException('scope');
 			}
 		}
 
 		if (
 			$property->getScope() === self::SCOPE_PRIVATE
 			&& in_array($property->getName(), [self::PROPERTY_DISPLAYNAME, self::PROPERTY_EMAIL])
 		) {
-			if ($throwOnData) {
-				// v2-private is not available for these fields
-				throw new InvalidArgumentException('scope');
-			} else {
-				// default to local
-				$property->setScope(self::SCOPE_LOCAL);
-			}
+			// v2-private is not available for these fields
+			throw new InvalidArgumentException('scope');
 		} else {
 			// migrate scope values to the new format
 			// invalid scopes are mapped to a default value
@@ -901,7 +888,7 @@ public function updateAccount(IAccount $account): void {
 		}
 
 		foreach ($account->getAllProperties() as $property) {
-			$this->testPropertyScope($property, self::ALLOWED_SCOPES, true);
+			$this->testPropertyScope($property, self::ALLOWED_SCOPES);
 		}
 
 		$oldData = $this->getUser($account->getUser(), false);

lib/public/Accounts/IAccountManager.php

@@ -151,7 +151,7 @@ interface IAccountManager {
 	 * published to the global lookup server or shared via federation.
 	 * This matches the frontend's UNPUBLISHED_READABLE_PROPERTIES constant.
 	 *
-	 * @since 32.0.0
+	 * @since 34.0.0
 	 */
 	public const UNPUBLISHED_PROPERTIES = [
 		self::PROPERTY_BIOGRAPHY,