fix(settings): get app updates only when appstore is enabled

Signed-off-by: Kent Delante <kent@delante.me>

Author: leftybournes

apps/settings/lib/Controller/AppSettingsController.php

@@ -55,6 +55,7 @@ class AppSettingsController extends Controller {
 
 	/** @var array */
 	private $allApps = [];
+	private bool $appstoreEnabled = true;
 
 	private IAppData $appData;
 
@@ -80,6 +81,7 @@ public function __construct(
 	) {
 		parent::__construct($appName, $request);
 		$this->appData = $appDataFactory->get('appstore');
+		$this->appstoreEnabled = $this->config->getSystemValueBool('appstoreenabled', true);
 	}
 
 	/**
@@ -90,10 +92,10 @@ public function __construct(
 	#[NoCSRFRequired]
 	public function viewApps(): TemplateResponse {
 		$this->navigationManager->setActiveEntry('core_apps');
-
-		$this->initialState->provideInitialState('appstoreEnabled', $this->config->getSystemValueBool('appstoreenabled', true));
+		
+		$this->initialState->provideInitialState('appstoreEnabled', $this->appstoreEnabled);
 		$this->initialState->provideInitialState('appstoreBundles', $this->getBundles());
-		$this->initialState->provideInitialState('appstoreUpdateCount', count($this->getAppsWithUpdates()));
+		$this->initialState->provideInitialState('appstoreUpdateCount', $this->appstoreEnabled ? count($this->getAppsWithUpdates()) : 0);
 		$this->initialState->provideInitialState('isAllInOne', filter_var(getenv('THIS_IS_AIO'), FILTER_VALIDATE_BOOL));
 
 		$groups = array_map(static fn (IGroup $group): array => [
@@ -256,6 +258,7 @@ private function cleanUpImageCache(ISimpleFolder $folder, string $etag): void {
 	private function getAppsWithUpdates() {
 		$appClass = new \OC_App();
 		$apps = $appClass->listAllApps();
+
 		foreach ($apps as $key => $app) {
 			$newVersion = $this->installer->isUpdateAvailable($app['id']);
 			if ($newVersion === false) {
@@ -385,9 +388,11 @@ public function listApps(): JSONResponse {
 				$appData['releases'] = $appstoreData['releases'];
 			}
 
-			$newVersion = $this->installer->isUpdateAvailable($appData['id']);
-			if ($newVersion) {
-				$appData['update'] = $newVersion;
+			if ($this->appstoreEnabled) {
+				$newVersion = $this->installer->isUpdateAvailable($appData['id']);
+				if ($newVersion) {
+					$appData['update'] = $newVersion;
+				}
 			}
 
 			// fix groups to be an array