fix: better applicable check for updating external mounts

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/files_external/lib/Service/MountCacheService.php

@@ -194,10 +194,26 @@ private function registerForUser(IUser $user, StorageConfig $storage): void {
 		);
 	}
 
+	private function isApplicableForUser(StorageConfig $storage, IUser $user): bool {
+		if (count($storage->getApplicableUsers()) + count($storage->getApplicableGroups()) === 0) {
+			return true;
+		}
+		if (in_array($user->getUID(), $storage->getApplicableUsers())) {
+			return true;
+		}
+		$groupIds = $this->groupManager->getUserGroupIds($user);
+		foreach ($groupIds as $groupId) {
+			if (in_array($groupId, $storage->getApplicableGroups())) {
+				return true;
+			}
+		}
+		return false;
+	}
+
 	private function handleUserRemoved(IGroup $group, IUser $user): void {
 		$storages = $this->storagesService->getAllStoragesForGroup($group);
 		foreach ($storages as $storage) {
-			if (!in_array($user->getUID(), $storage->getApplicableUsers())) {
+			if (!$this->isApplicableForUser($storage, $user)) {
 				$this->userMountCache->removeMount($storage->getMountPointForUser($user));
 			}
 		}
@@ -214,7 +230,7 @@ private function handleGroupDeleted(IGroup $group): void {
 		$storages = $this->storagesService->getAllStoragesForGroup($group);
 		foreach ($storages as $storage) {
 			foreach ($group->searchUsers('') as $user) {
-				if (!in_array($user->getUID(), $storage->getApplicableUsers())) {
+				if (!$this->isApplicableForUser($storage, $user)) {
 					$this->userMountCache->removeMount($storage->getMountPointForUser($user));
 				}
 			}