Merge pull request #59722 from nextcloud/bugfix/noid/still-sign-deprecated-ncu

fix(federation): Also sign requests with NCU providers

Author: CarlSchwan

apps/cloud_federation_api/lib/Controller/RequestHandlerController.php

@@ -488,7 +488,7 @@ private function confirmNotificationIdentity(
 
 		try {
 			$provider = $this->cloudFederationProviderManager->getCloudFederationProvider($resourceType);
-			if ($provider instanceof ISignedCloudFederationProvider) {
+			if ($provider instanceof ISignedCloudFederationProvider || $provider instanceof \NCU\Federation\ISignedCloudFederationProvider) {
 				$identity = $provider->getFederationIdFromSharedSecret($sharedSecret, $notification);
 			} else {
 				$this->logger->debug('cloud federation provider {provider} does not implements ISignedCloudFederationProvider', ['provider' => $provider::class]);

build/psalm-baseline.xml

@@ -37,6 +37,7 @@
 			'preLoginNameUsedAsUserName',
 			['uid' => &$uid]
 		)]]></code>
+      <code><![CDATA[getFederationIdFromSharedSecret]]></code>
     </DeprecatedMethod>
   </file>
   <file src="apps/comments/lib/Activity/Listener.php">