fix: Try to fix flaky cypress tests

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>

Author: DerDreschner

cypress/e2e/files/FilesUtils.ts

@@ -63,24 +63,41 @@ export function getInlineActionEntryForFile(file: string, actionId: string) {
 }
 
 /**
- * Open the actions menu of a file row and wait until it is really open.
+ * Whether the menu controlled by the given toggle is actually shown.
+ * The toggle state (aria-expanded) is not enough: async row re-renders
+ * (preview and share-status loading) can interrupt the popover while it
+ * is positioning, leaving a "zombie" menu that the NcActions component
+ * considers open but that is never displayed.
  *
- * Async row re-renders (preview and share-status loading) re-mount the
- * NcActions component, which silently closes a menu that was just opened.
- * So click only while the toggle reports "closed" and poll aria-expanded,
- * retrying until the open state sticks.
+ * @param $toggle the actions menu toggle of the row
+ */
+function isActionsMenuVisible($toggle: JQuery<HTMLElement>): boolean {
+	const menuId = $toggle.attr('aria-controls')
+	return Boolean(menuId) && Cypress.$(`#${menuId}`).is(':visible')
+}
+
+/**
+ * Open the actions menu of a file row and wait until it is really shown.
+ * Clicks the toggle, then polls the menu visibility: a hidden menu gets
+ * closed and re-opened (recovering the zombie state described above),
+ * retrying until the menu is displayed.
  *
  * @param getActionButton query for the actions menu toggle of the row
  * @param attempts remaining retries before giving up
  */
 function openActionsMenu(getActionButton: () => Cypress.Chainable<JQuery<HTMLElement>>, attempts = 5) {
 	getActionButton().then(($toggle) => {
-		if ($toggle.attr('aria-expanded') !== 'true') {
-			cy.wrap($toggle).click({ force: true }) // force to avoid issues with overlaying file list header
+		if (isActionsMenuVisible($toggle)) {
+			return
+		}
+		if ($toggle.attr('aria-expanded') === 'true') {
+			// Zombie state: close the menu first so the next click re-opens it cleanly
+			cy.wrap($toggle).click({ force: true })
 		}
+		cy.wrap($toggle).click({ force: true }) // force to avoid issues with overlaying file list header
 	})
 	getActionButton().then(($toggle) => {
-		if ($toggle.attr('aria-expanded') === 'true') {
+		if (isActionsMenuVisible($toggle)) {
 			return
 		}
 		if (attempts <= 0) {