fix(tests): replace checkbox assertions with DoesNotPerformAssertions (middleware)

Replace `addToAssertionCount(1)` placeholders in AppFramework middleware
tests that only verify no exception is thrown.

For `SameSiteCookieMiddlewareTest`, two tests already have
`expects(self::once())` mock expectations as their real assertion — those
just have the redundant placeholder removed. The third test has no
expectations and gets `#[DoesNotPerformAssertions]`.

For `SecurityMiddlewareTest`, `testIsSubAdminCheck` and
`testIsSubAdminAndAdminCheck` get `#[DoesNotPerformAssertions]`.
`testRestrictedAppLoggedInPublicPage` and `testRestrictedAppNotLoggedInPublicPage`
have `->with()` argument constraints that count as assertions in PHPUnit 11,
so the redundant placeholder is simply removed.

Part of a broader effort to eliminate checkbox tests (see also #60742, #60747).

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: miaulalala

tests/lib/AppFramework/Middleware/Security/SameSiteCookieMiddlewareTest.php

@@ -50,12 +50,12 @@ protected function setUp(): void {
 		$this->middleware = new SameSiteCookieMiddleware($this->request, new MiddlewareUtils($this->reflector, $this->logger));
 	}
 
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testBeforeControllerNoIndex(): void {
 		$this->request->method('getScriptName')
 			->willReturn('/ocs/v2.php');
 
 		$this->middleware->beforeController(new NoAnnotationController('foo', $this->request), 'foo');
-		$this->addToAssertionCount(1);
 	}
 
 	public function testBeforeControllerIndexHasAnnotation(): void {
@@ -68,7 +68,6 @@ public function testBeforeControllerIndexHasAnnotation(): void {
 			->willReturn(true);
 
 		$this->middleware->beforeController(new HasAnnotationController('foo', $this->request), 'foo');
-		$this->addToAssertionCount(1);
 	}
 
 	public function testBeforeControllerIndexNoAnnotationPassingCheck(): void {
@@ -84,7 +83,6 @@ public function testBeforeControllerIndexNoAnnotationPassingCheck(): void {
 			->willReturn(true);
 
 		$this->middleware->beforeController(new NoAnnotationController('foo', $this->request), 'foo');
-		$this->addToAssertionCount(1);
 	}
 
 	public function testBeforeControllerIndexNoAnnotationFailingCheck(): void {

tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php

@@ -470,21 +470,21 @@ public function testIsNotSubAdminCheck(string $method): void {
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataNoCSRFRequiredSubAdminRequired')]
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testIsSubAdminCheck(string $method): void {
 		$this->reader->reflect($this->controller, $method);
 		$sec = $this->getMiddleware(true, false, true);
 
 		$sec->beforeController($this->controller, $method);
-		$this->addToAssertionCount(1);
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataNoCSRFRequiredSubAdminRequired')]
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testIsSubAdminAndAdminCheck(string $method): void {
 		$this->reader->reflect($this->controller, $method);
 		$sec = $this->getMiddleware(true, true, true);
 
 		$sec->beforeController($this->controller, $method);
-		$this->addToAssertionCount(1);
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataNoCSRFRequired')]
@@ -506,7 +506,6 @@ public function testRestrictedAppLoggedInPublicPage(string $method): void {
 			->willReturn(false);
 
 		$middleware->beforeController($this->controller, $method);
-		$this->addToAssertionCount(1);
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataNoAdminRequiredNoCSRFRequiredPublicPage')]
@@ -523,7 +522,6 @@ public function testRestrictedAppNotLoggedInPublicPage(string $method): void {
 			->willReturn(false);
 
 		$middleware->beforeController($this->controller, $method);
-		$this->addToAssertionCount(1);
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataNoAdminRequiredNoCSRFRequired')]