feature(storage): Add symlink, is_link and readlink to IStorage, Wrapper and Common storage and View

Author: taminob

lib/private/Files/Storage/Common.php

@@ -121,6 +121,10 @@ public function is_file($path) {
 		return $this->filetype($path) === 'file';
 	}
 
+	public function is_link($path) {
+		return $this->filetype($path) === 'link';
+	}
+
 	public function filesize($path): false|int|float {
 		if ($this->is_dir($path)) {
 			return 0; //by definition

lib/private/Files/Storage/Local.php

@@ -326,17 +326,14 @@ public function file_put_contents($path, $data) {
 		return $result;
 	}
 
-	/**
-	 * create symlink
-	 *
-	 * @param string $path
-	 * @param string $target
-	 * @return bool
-	 */
 	public function symlink($target, $path) {
 		return symlink($target, $this->getSourcePath($path));
 	}
 
+	public function readlink($path) {
+		return readlink($this->getSourcePath($path));
+	}
+
 	public function unlink($path) {
 		if ($this->is_dir($path)) {
 			return $this->rmdir($path);

lib/private/Files/Storage/Wrapper/Wrapper.php

@@ -104,6 +104,26 @@ public function opendir($path) {
 		return $this->getWrapperStorage()->opendir($path);
 	}
 
+	/**
+	 * see https://www.php.net/manual/en/function.symlink.php
+	 *
+	 * @param string $path
+	 * @return string|false
+	 */
+	public function symlink($target, $link) {
+		return $this->getWrapperStorage()->symlink($target, $link);
+	}
+
+	/**
+	 * see https://www.php.net/manual/en/function.readlink.php
+	 *
+	 * @param string $path
+	 * @return string|false
+	 */
+	public function readlink($path) {
+		return $this->getWrapperStorage()->readlink($path);
+	}
+
 	/**
 	 * see https://www.php.net/manual/en/function.is_dir.php
 	 *
@@ -124,6 +144,16 @@ public function is_file($path) {
 		return $this->getWrapperStorage()->is_file($path);
 	}
 
+	/**
+	 * see https://www.php.net/manual/en/function.is_link.php
+	 *
+	 * @param string $path
+	 * @return bool
+	 */
+	public function is_link($path) {
+		return $this->getWrapperStorage()->is_link($path);
+	}
+
 	/**
 	 * see https://www.php.net/manual/en/function.stat.php
 	 * only the following keys are required in the result: size and mtime

lib/private/Files/View.php

@@ -410,6 +410,33 @@ public function readfile($path) {
 		return false;
 	}
 
+	/**
+	 * Return symlink target of given symlink
+	 *
+	 * @param string $path
+	 * @return mixed
+	 * @throws LockedException
+	 * @throws InvalidPathException
+	 */
+	public function readlink($path) {
+		$this->assertPathLength($path);
+		return $this->basicOperation('readlink', $path, ['read']);
+	}
+
+	/**
+	 * Create symlink at given path to the specified target
+	 *
+	 * @param string $target
+	 * @param string $path
+	 * @return mixed
+	 * @throws LockedException
+	 * @throws InvalidPathException
+	 */
+	public function symlink($target, $path) {
+		$this->assertPathLength($path);
+		return $this->basicOperation('symlink', $path, ['create', 'write'], $target);
+	}
+
 	/**
 	 * @param string $path
 	 * @param int $from

lib/public/Files/Storage/IStorage.php

@@ -108,6 +108,15 @@ public function is_dir($path);
 	 */
 	public function is_file($path);
 
+	/**
+	 * see https://www.php.net/manual/en/function.is-link.php
+	 *
+	 * @param string $path
+	 * @return bool
+	 * @since TODO
+	 */
+	public function is_link($path);
+
 	/**
 	 * see https://www.php.net/manual/en/function.stat.php
 	 * only the following keys are required in the result: size and mtime
@@ -238,6 +247,25 @@ public function file_put_contents($path, $data);
 	 */
 	public function unlink($path);
 
+	/**
+	 * see https://www.php.net/manual/en/function.symlink.php
+	 *
+	 * @param string $target
+	 * @param string $link
+	 * @return bool
+	 * @since TODO
+	 */
+	public function symlink($target, $link);
+
+	/**
+	 * see https://www.php.net/manual/en/function.readlink.php
+	 *
+	 * @param string $path
+	 * @return string|false
+	 * @since TODO
+	 */
+	public function readlink($path);
+
 	/**
 	 * see https://www.php.net/manual/en/function.rename.php
 	 *