Merge pull request #60744 from nextcloud/test/noid/phpunit-db-test-isolation

test(db): call parent::tearDown() in DB test classes that skipped it

Author: provokateurin

tests/lib/Calendar/ResourcesRoomsUpdaterTest.php

@@ -68,6 +68,7 @@ protected function tearDown(): void {
 		$query->delete('calendar_resources_md')->executeStatement();
 		$query->delete('calendar_rooms')->executeStatement();
 		$query->delete('calendar_rooms_md')->executeStatement();
+		parent::tearDown();
 	}
 
 	/**

tests/lib/DB/AdapterTest.php

@@ -29,6 +29,7 @@ public function tearDown(): void {
 			->from('appconfig')
 			->where($qb->expr()->eq('appid', $qb->createNamedParameter($this->appId)))
 			->executeStatement();
+		parent::tearDown();
 	}
 
 	public function testInsertIgnoreOnConflictDuplicate(): void {

tests/lib/Files/Config/UserMountCacheTest.php

@@ -90,6 +90,7 @@ protected function tearDown(): void {
 				->where($builder->expr()->eq('fileid', new Literal($fileId)))
 				->executeStatement();
 		}
+		parent::tearDown();
 	}
 
 	private function getStorage($storageId, $rootInternalPath = '') {

tests/lib/Files/Type/LoaderTest.php

@@ -31,6 +31,7 @@ protected function tearDown(): void {
 				'mimetype', $deleteMimetypes->createPositionalParameter('testing/%')
 			));
 		$deleteMimetypes->executeStatement();
+		parent::tearDown();
 	}
 
 

tests/lib/Preview/PreviewMigrationJobTest.php

@@ -103,6 +103,7 @@ public function tearDown(): void {
 		$qb->delete('filecache')
 			->where($qb->expr()->eq('fileid', $qb->createNamedParameter(5)))
 			->executeStatement();
+		parent::tearDown();
 	}
 
 	#[TestDox('Test the migration from the legacy flat hierarchy to the new database format')]

tests/lib/Share20/DefaultShareProviderTest.php

@@ -127,6 +127,7 @@ protected function tearDown(): void {
 		$this->dbConn->getQueryBuilder()->delete('share')->executeStatement();
 		$this->dbConn->getQueryBuilder()->delete('filecache')->runAcrossAllShards()->executeStatement();
 		$this->dbConn->getQueryBuilder()->delete('storages')->executeStatement();
+		parent::tearDown();
 	}
 
 	/**

tests/lib/Share20/ShareByMailProviderTest.php

@@ -134,6 +134,7 @@ protected function tearDown(): void {
 		$this->dbConn->getQueryBuilder()->delete('share')->executeStatement();
 		$this->dbConn->getQueryBuilder()->delete('filecache')->runAcrossAllShards()->executeStatement();
 		$this->dbConn->getQueryBuilder()->delete('storages')->executeStatement();
+		parent::tearDown();
 	}
 
 	/**

tests/lib/SubAdminTest.php

@@ -100,6 +100,7 @@ protected function tearDown(): void {
 			->where($qb->expr()->eq('uid', $qb->createNamedParameter('orphanedUser')))
 			->orWhere($qb->expr()->eq('gid', $qb->createNamedParameter('orphanedGroup')))
 			->executeStatement();
+		parent::tearDown();
 	}
 
 	public function testCreateSubAdmin(): void {