Skip to content

Commit f793aa3

Browse files
miaulalalamiaulalala
committed
test(ci): enforce PHPUnit time limits with sensible timeout values
PHPUnit's enforceTimeLimit was disabled, meaning the timeoutForSmallTests, timeoutForMediumTests and timeoutForLargeTests config values had no effect. Enable enforcement and set realistic limits: 60s/300s/600s for small/medium/large, with a 300s default for unannotated tests. Also clear disable_functions in the PHP development ini preset across all PHPUnit workflows so pcntl_signal is available — without it the signal handler that drives timeout enforcement cannot be registered. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
1 parent b8f2dd4 commit f793aa3

16 files changed

Lines changed: 25 additions & 6 deletions

‎.github/workflows/files-external-s3.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ jobs:
8888
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
8989
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
9090
ini-file: development
91+
ini-values: disable_functions=""
9192
env:
9293
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9394

@@ -177,6 +178,7 @@ jobs:
177178
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
178179
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
179180
ini-file: development
181+
ini-values: disable_functions=""
180182
env:
181183
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
182184

‎.github/workflows/files-external-smb.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ jobs:
8989
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, smbclient, sqlite, pdo_sqlite
9090
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
9191
ini-file: development
92+
ini-values: disable_functions=""
9293
env:
9394
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9495

‎.github/workflows/files-external-webdav.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ jobs:
8484
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
8585
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
8686
ini-file: development
87+
ini-values: disable_functions=""
8788
env:
8889
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8990

‎.github/workflows/files-external.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ jobs:
7878
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
7979
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
8080
ini-file: development
81+
ini-values: disable_functions=""
8182
env:
8283
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8384

‎.github/workflows/object-storage-azure.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ jobs:
9393
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
9494
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
9595
ini-file: development
96+
ini-values: disable_functions=""
9697
env:
9798
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9899

‎.github/workflows/object-storage-s3.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ jobs:
9494
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
9595
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
9696
ini-file: development
97+
ini-values: disable_functions=""
9798
env:
9899
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
99100

‎.github/workflows/object-storage-swift.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ jobs:
9191
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
9292
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
9393
ini-file: development
94+
ini-values: disable_functions=""
9495
env:
9596
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9697

‎.github/workflows/phpunit-mariadb.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ jobs:
106106
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
107107
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
108108
ini-file: development
109+
ini-values: disable_functions=""
109110
env:
110111
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
111112

‎.github/workflows/phpunit-memcached.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ jobs:
8686
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, memcached, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
8787
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
8888
ini-file: development
89+
ini-values: disable_functions=""
8990
env:
9091
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9192

‎.github/workflows/phpunit-mysql-sharding.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ jobs:
135135
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
136136
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
137137
ini-file: development
138+
ini-values: disable_functions=""
138139
env:
139140
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
140141

0 commit comments

Comments
 (0)