Skip to content

Commit f89613b

Browse files
abhinavohriChristophWurst
authored andcommitted
refactor(testing): Rename mock trait classes for clarity
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
1 parent 252956d commit f89613b

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

apps/files_external/tests/FrontendDefinitionTraitTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
use OCA\Files_External\Lib\FrontendDefinitionTrait;
1212
use OCA\Files_External\Lib\StorageConfig;
1313

14-
class MockFrontendDefinitionTrait {
14+
class MockFrontendDefinitionTraitClass {
1515
use FrontendDefinitionTrait;
1616
}
1717

@@ -22,7 +22,7 @@ public function testJsonSerialization(): void {
2222
->getMock();
2323
$param->method('getName')->willReturn('foo');
2424

25-
$trait = new MockFrontendDefinitionTrait();
25+
$trait = new MockFrontendDefinitionTraitClass();
2626
$trait->setText('test');
2727
$trait->addParameters([$param]);
2828
$trait->addCustomJs('foo/bar.js');
@@ -71,7 +71,7 @@ public function testValidateStorage(bool $expectedSuccess, array $params): void
7171
$storageConfig->expects($this->any())
7272
->method('setBackendOption');
7373

74-
$trait = new MockFrontendDefinitionTrait();
74+
$trait = new MockFrontendDefinitionTraitClass();
7575
$trait->setText('test');
7676
$trait->addParameters($backendParams);
7777

@@ -102,7 +102,7 @@ public function testValidateStorageSet(): void {
102102
->method('setBackendOption')
103103
->with('param', 'foobar');
104104

105-
$trait = new MockFrontendDefinitionTrait();
105+
$trait = new MockFrontendDefinitionTraitClass();
106106
$trait->setText('test');
107107
$trait->addParameter($param);
108108

apps/files_external/tests/LegacyDependencyCheckPolyfillTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
1212
use OCA\Files_External\Lib\MissingDependency;
1313

14-
class MockLegacyDependencyCheckPolyfill {
14+
class MockLegacyDependencyCheckPolyfillClass {
1515
use LegacyDependencyCheckPolyfill;
1616

1717
public function getStorageClass(): string {
@@ -32,7 +32,7 @@ public static function checkDependencies(): array {
3232
}
3333

3434
public function testCheckDependencies(): void {
35-
$trait = new MockLegacyDependencyCheckPolyfill();
35+
$trait = new MockLegacyDependencyCheckPolyfillClass();
3636

3737
$dependencies = $trait->checkDependencies();
3838
$this->assertCount(2, $dependencies);

apps/settings/tests/SetupChecks/SecurityHeadersTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ protected function setupResponse(int $statuscode, array $headers): void {
182182
$this->setupcheck
183183
->expects($this->atLeastOnce())
184184
->method('runRequest')
185-
->willReturn($this->generate([$response]));
185+
->willReturn($this->generate([$response]));
186186
}
187187

188188
/**

0 commit comments

Comments
 (0)