perf(comments): Add a way to get comments for multiple objects at the same time

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>

Author: Carl Schwan

lib/private/Comments/Manager.php

@@ -625,14 +625,17 @@ public function searchForObjects(string $search, string $objectType, array $obje
 	 * @return Int
 	 * @since 9.0.0
 	 */
-	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '') {
+	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = ''): int {
+		return $this->getNumberOfCommentsForObjects($objectType, [$objectId], $notOlderThan, $verb)[$objectId];
+	}
+
+	/** @inheritDoc */
+	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array {
 		$qb = $this->dbConn->getQueryBuilder();
-		$query = $qb->select($qb->func()->count('id'))
+		$query = $qb->select($qb->func()->count('id'), 'object_id')
 			->from('comments')
-			->where($qb->expr()->eq('object_type', $qb->createParameter('type')))
-			->andWhere($qb->expr()->eq('object_id', $qb->createParameter('id')))
-			->setParameter('type', $objectType)
-			->setParameter('id', $objectId);
+			->where($qb->expr()->eq('object_type', $qb->createNamedParameter($objectType, IQueryBuilder::PARAM_STR)))
+			->andWhere($qb->expr()->in('object_id', $qb->createNamedParameter($objectIds, IQueryBuilder::PARAM_STR_ARRAY)));
 
 		if (!is_null($notOlderThan)) {
 			$query
@@ -644,10 +647,15 @@ public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime
 			$query->andWhere($qb->expr()->eq('verb', $qb->createNamedParameter($verb)));
 		}
 
+		$query->groupBy('object_id');
+		$comments = array_fill_keys($objectIds, 0);
 		$resultStatement = $query->execute();
-		$data = $resultStatement->fetch(\PDO::FETCH_NUM);
+		while ($data = $resultStatement->fetch()) {
+			$comments[$data[1]] = (int)$data[0];
+		}
 		$resultStatement->closeCursor();
-		return (int)$data[0];
+
+		return $comments;
 	}
 
 	/**

lib/public/Comments/ICommentsManager.php

@@ -186,6 +186,17 @@ public function searchForObjects(string $search, string $objectType, array $obje
 	 */
 	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '');
 
+	/**
+	 * @param $objectType string the object type, e.g. 'files'
+	 * @param $objectIds string[] the ids of the object
+	 * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
+	 *                                     that may be returned
+	 * @param string $verb Limit the verb of the comment - Added in 14.0.0
+	 * @return array<string, int>
+	 * @since 32.0.0
+	 */
+	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = '');
+
 	/**
 	 * @param string $objectType the object type, e.g. 'files'
 	 * @param string[] $objectIds the id of the object

tests/lib/Comments/FakeManager.php

@@ -59,6 +59,10 @@ public function getCommentsWithVerbForObjectSinceComment(
 	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '') {
 	}
 
+	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = '') :array {
+		return array_fill_keys($objectIds, 0);
+	}
+
 	public function search(string $search, string $objectType, string $objectId, string $verb, int $offset, int $limit = 50): array {
 		return [];
 	}