Conversation
kesselb
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
nickvergessen and
tcitworld
as code owners
kesselb
requested review from
ArtificialOwl,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team
kesselb
commented
Apr 27, 2026
| abstract class PublicShareController extends Controller { | ||
|
|
||
| /** | ||
| * @since 33.0.0 |
Contributor
Author
There was a problem hiding this comment.
needs adjustment on backport
kesselb
commented
Apr 27, 2026
| /** | ||
| * Validate the token and password hash stored in session | ||
| * | ||
| * @since 33.0.0 |
Contributor
Author
There was a problem hiding this comment.
needs adjustment on backport
kesselb
commented
Apr 27, 2026
| /** | ||
| * Store the token and password hash in session | ||
| * | ||
| * @since 33.0.0 |
Contributor
Author
There was a problem hiding this comment.
needs adjustment on backport
kesselb
commented
Apr 27, 2026
| } | ||
|
|
||
| /** | ||
| * @since 34.0.0 |
Contributor
Author
There was a problem hiding this comment.
needs adjustment on backport
ChristophWurst
approved these changes
Apr 27, 2026
nickvergessen
approved these changes
Apr 28, 2026
Member
|
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/noid/fix-since-checker
branch
from
6e2ed11 to
25ca85e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The imports were missing, hence the checks not executed.
Ignoring since for private methods.
Checklist
3. to review, feature component)stable32)AI (if applicable)