Skip to content

Feat: Better reporting if something is wrong with taskprocessing#59958

Merged
marcelklehr merged 10 commits intomasterfrom
feat/setupcheck-taskprocessing-worker
Apr 29, 2026
Merged

Feat: Better reporting if something is wrong with taskprocessing#59958
marcelklehr merged 10 commits intomasterfrom
feat/setupcheck-taskprocessing-worker

Conversation

@marcelklehr
Copy link
Copy Markdown
Member

Summary

It turns out that the occ taskprocessing:worker command does not run when the instance is in maintenance mode and then usually just stops (after a few failed restarts). This adds a setup check to make the admin aware that the worker is not running, iff there have been scheduled tasks in the last 7 days (to make sure we don't warn if the feature is not used).
The second commit increases the sensitivity threshold for the other taskprocessing setup checks from 20% to 10% to make them warn earlier.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr added this to the Nextcloud 34 milestone Apr 28, 2026
@marcelklehr marcelklehr requested a review from a team as a code owner April 28, 2026 09:49
@marcelklehr marcelklehr requested review from Altahrim, leftybournes, nfebe and sorbaugh and removed request for a team April 28, 2026 09:49
@marcelklehr marcelklehr changed the title Feat/setupcheck taskprocessing worker Feat: Better reporting if something is wrong with taskprocessing Apr 28, 2026
Copy link
Copy Markdown
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the check results. I tried with no tasks recently scheduled and after having scheduled one.
There should always be one, right?

Comment thread apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php
Comment thread apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php Outdated
@marcelklehr
Copy link
Copy Markdown
Member Author

I don't see the check results.

Ah, it's not registered.

marcelklehr and others added 3 commits April 28, 2026 12:49
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Comment thread apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php Outdated
Comment thread apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php Outdated
Comment thread apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php Outdated
Copy link
Copy Markdown
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread apps/settings/tests/SetupChecks/TaskProcessingWorkerIsRunningTest.php Outdated
Comment thread core/Command/TaskProcessing/WorkerCommand.php Outdated
…as never run

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@julien-nc julien-nc self-requested a review April 28, 2026 13:59
Comment thread core/Command/TaskProcessing/WorkerCommand.php Outdated
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr enabled auto-merge April 29, 2026 09:04
@marcelklehr
Copy link
Copy Markdown
Member Author

/backport to stable33

@marcelklehr
Copy link
Copy Markdown
Member Author

/backport to stable32

@marcelklehr marcelklehr merged commit b2ffaaf into master Apr 29, 2026
193 of 199 checks passed
@marcelklehr marcelklehr deleted the feat/setupcheck-taskprocessing-worker branch April 29, 2026 10:07
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants