perf: cache server checks in local cache, not session#53684
Open
ChristophWurst wants to merge 3 commits into
Open
perf: cache server checks in local cache, not session#53684ChristophWurst wants to merge 3 commits into
ChristophWurst wants to merge 3 commits into
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
3. to review
ChristophWurst
requested review from
ArtificialOwl,
CarlSchwan,
provokateurin and
salmart-dev
and removed request for
a team
Member
Author
|
Let's do this |
Member
|
What was missing? 😅 |
provokateurin
approved these changes
May 20, 2026
Member
Author
|
IIRC I did this as a drive-by when I was working on something else, then I forgot about it 🙊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caching was added in owncloud/core#4441. It makes sense to cache the steps, but not on a user session level. The checks are global to the instance. Cache it for everyone, and make the cached value accessible to requests that do not use sessions.
Every time we read or write session the PHP session has to be opened. For a simple system that means disk IO, for a scaled setup that means network IO to contact Redis. Local cache (APCu) has low latency.
TODO
Checklist