Skip to content

fix(unified-search): Send ISO date strings#55478

Open
nfebe wants to merge 4 commits into
masterfrom
fix/search-date-filter-format
Open

fix(unified-search): Send ISO date strings#55478
nfebe wants to merge 4 commits into
masterfrom
fix/search-date-filter-format

Conversation

@nfebe

@nfebe nfebe commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Send expected ISO date string values for since and until.

See :

$this->value = new DateTimeImmutable($value);

@nfebe nfebe requested a review from a team as a code owner October 1, 2025 14:09
@nfebe nfebe added 3. to review Waiting for reviews feature: search labels Oct 1, 2025
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 📁 Files team Oct 1, 2025
@nfebe nfebe force-pushed the fix/search-date-filter-format branch from d41c453 to d307142 Compare October 1, 2025 14:09
@provokateurin

Copy link
Copy Markdown
Member

What is sent right now?

@joshtrichards joshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. From what I can tell, the pre-PR behavior already serializes Date params to ISO strings, but only implicitly. It might be worth adjusting the search() contract docs as well, or even instead:

* @param {string} options.since the search
* @param {string} options.until the search

e.g.

 * @param {string|undefined} options.since ISO datetime string
 * @param {string|undefined} options.until ISO datetime string

I was initially confused because the current JSDoc already says only strings are accepted, not Date objects. In practice, though, that seems misleading because the existing behavior relies on implicit serialization. This PR makes that behavior more explicit, which is good, but I’d still suggest the doc update for clarity.

@joshtrichards

Copy link
Copy Markdown
Member

/compile

@joshtrichards

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

nextcloud-command and others added 3 commits June 17, 2026 21:25
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
…ter-format

# Conflicts:
#	core/src/components/UnifiedSearch/UnifiedSearchModal.vue
…nto fix/search-date-filter-format

# Conflicts:
#	dist/core-unified-search.js
#	dist/core-unified-search.js.map

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Done — I resolved the merge conflicts and pushed the updates in commit 8f614d6 (including the prior conflict-resolution merge 8800ac3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: search technical debt 🧱 🤔🚀

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

7 participants