Skip to content

fix(DirectEditing): expose already used methods on the public interface#55993

Open
juliusknorr wants to merge 4 commits into
masterfrom
fix/direct-editing-interface
Open

fix(DirectEditing): expose already used methods on the public interface#55993
juliusknorr wants to merge 4 commits into
masterfrom
fix/direct-editing-interface

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Oct 24, 2025

Copy link
Copy Markdown
Member

These methods had been on the implementation and are used in text for a long time already. They should be exposed on the public interface so we can cleanup the psalm baseline:

@juliusknorr juliusknorr requested a review from a team as a code owner October 24, 2025 19:30
@juliusknorr juliusknorr requested review from Altahrim, leftybournes, salmart-dev and yemkareems and removed request for a team October 24, 2025 19:30
@juliusknorr juliusknorr added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 24, 2025
@juliusknorr juliusknorr force-pushed the fix/direct-editing-interface branch from 8951c3c to 027d1ca Compare October 24, 2025 20:09
Comment thread lib/public/DirectEditing/IManager.php Outdated
Comment thread lib/public/DirectEditing/IToken.php Outdated
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Jun 17, 2026
@joshtrichards joshtrichards force-pushed the fix/direct-editing-interface branch from 027d1ca to 2b1b96b Compare June 17, 2026 19:37
@joshtrichards joshtrichards changed the title fix: Expose already used public interface methods fix(DirectEditing): expose already used methods on the public interface Jun 17, 2026
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2026
@joshtrichards joshtrichards enabled auto-merge June 17, 2026 19:52
juliusknorr and others added 4 commits June 18, 2026 18:15
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@AndyScherzinger AndyScherzinger force-pushed the fix/direct-editing-interface branch from fbbc730 to abef770 Compare June 18, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants