fix: move download and enable button to outside of details tab by mykh-hailo · Pull Request #59465 · nextcloud/server

mykh-hailo · 2026-04-06T08:41:51Z

Resolves: App management: The "download and enable" button should be moved outside the sidebar tab #44125

Summary

This change improves discoverability of app lifecycle actions in the App Store sidebar by moving install, update, remove, enable/disable, App API deploy options, and “delete data on remove” out of the Details tab and into the sidebar header description area, next to badges and the store rating.

The Details tab now focuses on group limits, dependencies, metadata, and links (interact section), while primary actions stay visible without switching tabs.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

susnux · 2026-04-06T21:02:38Z

Can you please add screenshots?
How does this look on mobile?

mykh-hailo · 2026-04-07T08:23:36Z

@susnux Here are the screenshots before and update.

Screenshot for Wide Screens.

Before	After

Screenshot for narrow screens.

Before	After

P.S. We have the title and score and the button section is clipped on the left. To fix this issue, we have to fix NcAppSidebar component.

mykh-hailo · 2026-04-07T13:32:15Z

@susnux I updated the code with the latest master branch.
I'd appreciate it if you check it please.

mykh-hailo · 2026-04-08T06:47:54Z

@susnux , @skjnldsv
Can you possibly give me any feedback on this PR please?

mykh-hailo · 2026-04-09T14:01:13Z

@susnux , @skjnldsv , @szaimen , @nfebe , @sorbaugh
I'd appreciate it if you have time to review this PR.

artonge

Looks good overall

artonge

Looks good

szaimen

Hi @mykh-hailo thanks a lot for the contribution!

I just tested this and there seems to be some problems with the limit apps to groups feature (it should be put onto a new line probably and not be positioned like a block element:

Grabacion.2026-04-13.163329.mp4

Additionally, there seems to be some problems with updating the internal state when using the enable, install or disable buttons so that always a full page reload is required to update the state:

Grabacion.2026-04-13.163527.mp4

mykh-hailo · 2026-04-13T19:35:16Z

@szaimen Thank you for your comments.
I updated the code base for that.
I'd appreciate it if you review it again.

mykh-hailo · 2026-04-15T12:52:31Z

@szaimen I tested with docker image nextcloud:apache and Inter Fonts app, and the error is still reproduceable.

szaimen · 2026-04-15T13:30:03Z

@szaimen I tested with docker image nextcloud:apache and Inter Fonts app, and the error is still reproduceable.

Which error?

That the enable or remove buttons are not shown after didabling the app? But what if you reload the page?

mykh-hailo · 2026-04-15T13:48:02Z

@szaimen I tested with docker image nextcloud:apache and Inter Fonts app, and the error is still reproduceable.

Which error?

That the enable or remove buttons are not shown after didabling the app? But what if you reload the page?

Yes, the actions section on the sidebar is not updated until we reload the page.
Once reload, it shows proper buttons.
Here is screen recording.

2026-04-15.09-41-35.mov

szaimen · 2026-04-15T13:57:21Z

Yes, the actions section on the sidebar is not updated until we reload the page.
Once reload, it shows proper buttons.
Here is screen recording.

I see. However you fixed this right?

My problem with your fix is thst in my testing it shows the wrong buttons after clicking on disable on a non-shipped app. (It shows one button: download and enable instead of two buttons: remove or enable)

mykh-hailo · 2026-04-15T14:10:09Z

Yes, the actions section on the sidebar is not updated until we reload the page.
Once reload, it shows proper buttons.
Here is screen recording.

I see. However you fixed this right?

My problem with your fix is thst in my testing it shows the wrong buttons after clicking on disable on a non-shipped app. (It shows one button: download and enable instead of two buttons: remove or enable)

No, This PR does not contain the fix.
As I mentioned #59465 (comment), I need to look more to fix this issue.
Therefore, my idea is to make an issue for that bug and work on it on a separate branch.
What do you think?

szaimen · 2026-04-15T14:11:50Z

Therefore, my idea is to make an issue for that bug and work on it on a separate branch.
What do you think?

Sounds good :)

mykh-hailo · 2026-04-15T14:30:43Z

@szaimen can we merge this branch now?

szaimen · 2026-04-15T14:51:11Z

@szaimen can we merge this branch now?

I just tested again and this bug still seems to be there:

2. Activating the checkbox to limit an app to a specific group always shows No results. Instead it should show a dropdown that allows to select your groups

(I did not recompile locally)

mykh-hailo · 2026-04-15T15:19:24Z

@szaimen sorry, I forgot to push the build file.
Can you check it again please?

mykh-hailo · 2026-04-16T06:58:10Z

@szaimen Can you help me to merge this PR ASAP please?

szaimen

Tested with some culprits but did not review the code.

The culprits:

The buttons do not update whenever clicked. A page reload is needed.
The same applies to limiting apps to groups.

@mykh-hailo please handle these in a follow-up if possible :)

mykh-hailo · 2026-04-16T12:14:36Z

@artonge , @susnux , @szaimen
Can you give me the ETA for this merge please?

szaimen · 2026-04-16T12:16:24Z

@artonge , @susnux , @szaimen Can you give me the ETA for this merge please?

@mykh-hailo sorry cannot give you any ETA. However please fix the red CI. Failing tests are related afaics. Then we can move forward with trying to merge this.

mykh-hailo · 2026-04-16T16:26:42Z

@susnux can you check this PR if it can be merged?

mykh-hailo · 2026-04-17T06:40:23Z

@susnux can you help me to merge this PR?

mykh-hailo · 2026-04-17T14:35:40Z

@susnux , it's been 2 weeks since I made PR.
Can you help me to approve this PR asap please?

szaimen · 2026-04-17T14:37:46Z

@susnux , it's been 2 weeks since I made PR. Can you help me to approve this PR asap please?

@mykh-hailo please fix the tests. Then we can go forward with merging this PR.

mykh-hailo · 2026-04-17T14:51:06Z

@szaimen I don't think the errors are caused by me.
I've seen the errors before but PRs was merged successfully.

szaimen · 2026-04-17T15:01:23Z

The following error sounds related:


 1) Settings: App management
       Browse enabled apps:
     CypressError: Timed out retrying after 4000ms: `cy.should()` failed because the page updated as a result of this command, but you tried to continue the command chain. The subject is no longer attached to the DOM, and Cypress cannot requery the page after commands such as `cy.should()`.

Common situations why this happens:
  - Your JS framework re-rendered asynchronously
  - Your app code reacted to an event firing and removed the element

You can typically solve this by breaking up a chain. For example, rewrite:

> `cy.get('button').click().should('have.class', 'active')`

to

> `cy.get('button').as('btn').click()`
> `cy.get('@btn').should('have.class', 'active')`

https://on.cypress.io/element-has-detached-from-dom
      at Object.isAttached (http://localhost:8042/__cypress/runner/cypress_runner.js:153271:58)
      at applyChainers (http://localhost:8042/__cypress/runner/cypress_runner.js:122342:24)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Promise.attempt.Promise.try (http://localhost:8042/__cypress/runner/cypress_runner.js:4285:29)
      at Context.shouldFn (http://localhost:8042/__cypress/runner/cypress_runner.js:122370:66)
      at Context.should (http://localhost:8042/__cypress/runner/cypress_runner.js:122387:23)
      at <unknown> (http://localhost:8042/__cypress/runner/cypress_runner.js:151285:39)
      at assertions (http://localhost:8042/__cypress/runner/cypress_runner.js:151533:16)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Object.gotValue (http://localhost:8042/__cypress/runner/cypress_runner.js:6448:18)
      at Object.gotAccum (http://localhost:8042/__cypress/runner/cypress_runner.js:6435:25)
      at Object.tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Promise._settlePromiseFromHandler (http://localhost:8042/__cypress/runner/cypress_runner.js:1489:31)
      at Promise._settlePromise (http://localhost:8042/__cypress/runner/cypress_runner.js:1546:18)
      at Promise._settlePromiseCtx (http://localhost:8042/__cypress/runner/cypress_runner.js:1583:10)
      at _drainQueueStep (http://localhost:8042/__cypress/runner/cypress_runner.js:2381:12)
      at _drainQueue (http://localhost:8042/__cypress/runner/cypress_runner.js:2370:9)
      at Async._drainQueues (http://localhost:8042/__cypress/runner/cypress_runner.js:2386:5)
      at Async.drainQueues (http://localhost:8042/__cypress/runner/cypress_runner.js:2256:14)
  From Your Spec Code:
      at Context.eval (http://localhost:8042/__cypress/tests?p=cypress/e2e/settings/apps.cy.ts:59:26)
      at Context.callback (http://localhost:8042/__cypress/runner/cypress_runner.js:123042:26)
      at getRet (http://localhost:8042/__cypress/runner/cypress_runner.js:122807:20)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Promise.attempt.Promise.try (http://localhost:8042/__cypress/runner/cypress_runner.js:4285:29)
      at thenFn (http://localhost:8042/__cypress/runner/cypress_runner.js:122818:66)
      at yieldItem (http://localhost:8042/__cypress/runner/cypress_runner.js:123050:16)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Object.gotValue (http://localhost:8042/__cypress/runner/cypress_runner.js:6446:18)

  2) Settings: App management
       Browse disabled apps:
     CypressError: Timed out retrying after 4000ms: `cy.should()` failed because the page updated as a result of this command, but you tried to continue the command chain. The subject is no longer attached to the DOM, and Cypress cannot requery the page after commands such as `cy.should()`.

Common situations why this happens:
  - Your JS framework re-rendered asynchronously
  - Your app code reacted to an event firing and removed the element

You can typically solve this by breaking up a chain. For example, rewrite:

> `cy.get('button').click().should('have.class', 'active')`

to

> `cy.get('button').as('btn').click()`
> `cy.get('@btn').should('have.class', 'active')`

https://on.cypress.io/element-has-detached-from-dom
      at Object.isAttached (http://localhost:8042/__cypress/runner/cypress_runner.js:153271:58)
      at applyChainers (http://localhost:8042/__cypress/runner/cypress_runner.js:122342:24)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Promise.attempt.Promise.try (http://localhost:8042/__cypress/runner/cypress_runner.js:4285:29)
      at Context.shouldFn (http://localhost:8042/__cypress/runner/cypress_runner.js:122370:66)
      at Context.should (http://localhost:8042/__cypress/runner/cypress_runner.js:122387:23)
      at <unknown> (http://localhost:8042/__cypress/runner/cypress_runner.js:151285:39)
      at assertions (http://localhost:8042/__cypress/runner/cypress_runner.js:151533:16)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Object.gotValue (http://localhost:8042/__cypress/runner/cypress_runner.js:6448:18)
      at Object.gotAccum (http://localhost:8042/__cypress/runner/cypress_runner.js:6435:25)
      at Object.tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Promise._settlePromiseFromHandler (http://localhost:8042/__cypress/runner/cypress_runner.js:1489:31)
      at Promise._settlePromise (http://localhost:8042/__cypress/runner/cypress_runner.js:1546:18)
      at Promise._settlePromiseCtx (http://localhost:8042/__cypress/runner/cypress_runner.js:1583:10)
      at _drainQueueStep (http://localhost:8042/__cypress/runner/cypress_runner.js:2381:12)
      at _drainQueue (http://localhost:8042/__cypress/runner/cypress_runner.js:2370:9)
      at Async._drainQueues (http://localhost:8042/__cypress/runner/cypress_runner.js:2386:5)
      at Async.drainQueues (http://localhost:8042/__cypress/runner/cypress_runner.js:2256:14)
  From Your Spec Code:
      at Context.eval (http://localhost:8042/__cypress/tests?p=cypress/e2e/settings/apps.cy.ts:67:26)
      at Context.callback (http://localhost:8042/__cypress/runner/cypress_runner.js:123042:26)
      at getRet (http://localhost:8042/__cypress/runner/cypress_runner.js:122807:20)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Promise.attempt.Promise.try (http://localhost:8042/__cypress/runner/cypress_runner.js:4285:29)
      at thenFn (http://localhost:8042/__cypress/runner/cypress_runner.js:122818:66)
      at yieldItem (http://localhost:8042/__cypress/runner/cypress_runner.js:123050:16)
      at tryCatcher (http://localhost:8042/__cypress/runner/cypress_runner.js:1777:23)
      at Object.gotValue (http://localhost:8042/__cypress/runner/cypress_runner.js:6446:18)




  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        7                                                                                │
  │ Passing:      5                                                                                │
  │ Failing:      2                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  11                                                                               │
  │ Video:        false                                                                            │
  │ Duration:     4 minutes, 15 seconds                                                            │
  │ Spec Ran:     settings/apps.cy.ts                                                              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Screenshots)

  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse enabled apps (failed).png                       
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse enabled apps (failed) (attempt 2)               
     .png                                                                                           
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse enabled apps (failed) (attempt 3)               
     .png                                                                                           
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse enabled apps (failed) (attempt 4)               
     .png                                                                                           
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse disabled apps (failed).png                      
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse disabled apps (failed) (attempt 2               
     ).png                                                                                          
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse disabled apps (failed) (attempt 3               
     ).png                                                                                          
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Browse disabled apps (failed) (attempt 4               
     ).png                                                                                          
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Limit app usage to group (failed).png                  
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Limit app usage to group (failed) (attem               
     pt 2).png                                                                                      
  -  /home/runner/actions-runner/_work/server/server/cypress/snapshots/actual/setting     (1280x720)
     s/apps.cy.ts/Settings App management -- Limit app usage to group (failed) (attem               
     pt 3).png

mykh-hailo · 2026-04-17T15:59:35Z

@szaimen I rebased the branch and it passed the test.
Can you check again please?

mykh-hailo · 2026-04-20T07:22:07Z

@susnux , @artonge can you help me to merge this PR please?
It's be weeks since I made this PR and sometimes it causes me much more extra time to resolve conflicts for the updates.

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

mykh-hailo requested a review from a team as a code owner April 6, 2026 08:41

mykh-hailo requested review from nfebe, sorbaugh and szaimen and removed request for a team April 6, 2026 08:41

susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 6, 2026

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from b77e55c to 6834740 Compare April 7, 2026 13:31

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 3 times, most recently from ad3aa25 to fb5dc2b Compare April 7, 2026 16:03

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 2 times, most recently from b8c5ed1 to 6bbca83 Compare April 9, 2026 09:38

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 6bbca83 to 5d71884 Compare April 9, 2026 14:36

mykh-hailo mentioned this pull request Apr 9, 2026

feat: remove password column from user table #59348

Merged

7 tasks

artonge reviewed Apr 10, 2026

View reviewed changes

Comment thread apps/settings/src/components/AppStoreSidebar/AppStoreSidebarActions.vue

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 5d71884 to 7dbb3fb Compare April 10, 2026 08:59

artonge approved these changes Apr 10, 2026

View reviewed changes

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 7dbb3fb to 51f2f6a Compare April 13, 2026 06:07

szaimen requested changes Apr 13, 2026

View reviewed changes

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 51f2f6a to a5fcfdf Compare April 13, 2026 19:34

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 3 times, most recently from 4de7f7a to 6fac68b Compare April 13, 2026 19:43

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 45a49ec to 96df71e Compare April 15, 2026 15:18

szaimen approved these changes Apr 16, 2026

View reviewed changes

szaimen added this to the Nextcloud 34 milestone Apr 16, 2026

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from 96df71e to 2e2f0a3 Compare April 17, 2026 15:25

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch 2 times, most recently from 990f517 to c26a82a Compare April 20, 2026 13:59

fix: move download and enable button to outside of details tab

6a0a1b2

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

mykh-hailo force-pushed the fix/app-download-and-enable-button-position branch from c26a82a to 6a0a1b2 Compare April 20, 2026 14:14

mykh-hailo requested review from artonge and szaimen April 20, 2026 14:57

Uh oh!

Conversation

mykh-hailo commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

AI (if applicable)

Uh oh!

susnux commented Apr 6, 2026

Uh oh!

mykh-hailo commented Apr 7, 2026

Screenshot for Wide Screens.

Screenshot for narrow screens.

Uh oh!

mykh-hailo commented Apr 7, 2026

Uh oh!

mykh-hailo commented Apr 8, 2026

Uh oh!

mykh-hailo commented Apr 9, 2026

Uh oh!

artonge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

artonge left a comment

Choose a reason for hiding this comment

Uh oh!

szaimen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 13, 2026

Uh oh!

mykh-hailo commented Apr 15, 2026

Uh oh!

szaimen commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mykh-hailo commented Apr 15, 2026

Uh oh!

szaimen commented Apr 15, 2026

Uh oh!

mykh-hailo commented Apr 15, 2026

Uh oh!

szaimen commented Apr 15, 2026

Uh oh!

mykh-hailo commented Apr 15, 2026

Uh oh!

szaimen commented Apr 15, 2026

Uh oh!

mykh-hailo commented Apr 15, 2026

Uh oh!

mykh-hailo commented Apr 16, 2026

Uh oh!

szaimen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 16, 2026

Uh oh!

szaimen commented Apr 16, 2026

Uh oh!

mykh-hailo commented Apr 16, 2026

Uh oh!

mykh-hailo commented Apr 17, 2026

Uh oh!

mykh-hailo commented Apr 17, 2026

Uh oh!

szaimen commented Apr 17, 2026

Uh oh!

mykh-hailo commented Apr 17, 2026

Uh oh!

szaimen commented Apr 17, 2026

Uh oh!

mykh-hailo commented Apr 17, 2026

Uh oh!

mykh-hailo commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

mykh-hailo commented Apr 6, 2026 •

edited

Loading

szaimen left a comment •

edited

Loading

szaimen commented Apr 15, 2026 •

edited

Loading

szaimen left a comment •

edited

Loading