Skip to content

fix(previews): fix chunking for querybuilder#59477

Merged
miaulalala merged 2 commits intomasterfrom
fix/noid/preview-scan-bulk-fetch-chunking
May 6, 2026
Merged

fix(previews): fix chunking for querybuilder#59477
miaulalala merged 2 commits intomasterfrom
fix/noid/preview-scan-bulk-fetch-chunking

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

@miaulalala miaulalala commented Apr 7, 2026

Summary

Fixes #59234 (comment)

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@miaulalala miaulalala added this to the Nextcloud 34 milestone Apr 7, 2026
@miaulalala miaulalala self-assigned this Apr 7, 2026
@miaulalala miaulalala requested a review from a team as a code owner April 7, 2026 10:33
@miaulalala miaulalala added the 3. to review Waiting for reviews label Apr 7, 2026
@miaulalala miaulalala requested review from CarlSchwan, come-nc, joshtrichards, leftybournes and salmart-dev and removed request for a team April 7, 2026 10:33
Copy link
Copy Markdown
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner to use a parameter and set it in the loop.
See

foreach (array_chunk($ids, 1000) as $chunk) {
for an example

@miaulalala miaulalala requested a review from come-nc May 4, 2026 16:59
@miaulalala miaulalala force-pushed the fix/noid/preview-scan-bulk-fetch-chunking branch 2 times, most recently from a5565fa to 70751b6 Compare May 5, 2026 07:52
Comment thread lib/private/Preview/Storage/LocalPreviewStorage.php Outdated
Comment thread lib/private/Preview/Storage/LocalPreviewStorage.php Outdated
miaulalala added 2 commits May 6, 2026 10:32
Signed-off-by: Anna Larch <anna@nextcloud.com>
…nk loop

AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@miaulalala miaulalala force-pushed the fix/noid/preview-scan-bulk-fetch-chunking branch from 70751b6 to 0681ced Compare May 6, 2026 08:33
@miaulalala miaulalala requested a review from provokateurin May 6, 2026 08:33
@miaulalala miaulalala enabled auto-merge May 6, 2026 11:50
@miaulalala miaulalala merged commit 5d7cdb8 into master May 6, 2026
224 of 233 checks passed
@miaulalala miaulalala deleted the fix/noid/preview-scan-bulk-fetch-chunking branch May 6, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants