refactor(files_versions): add conservative typing and improve Storage phpdoc#59537
Draft
joshtrichards wants to merge 9 commits into
Draft
refactor(files_versions): add conservative typing and improve Storage phpdoc#59537joshtrichards wants to merge 9 commits into
joshtrichards wants to merge 9 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
…eter typing Signed-off-by: Josh <josh.t.richards@gmail.com>
To Storage::getUidAndFilename() Signed-off-by: Josh <josh.t.richards@gmail.com>
…ge functions Signed-off-by: Josh <josh.t.richards@gmail.com>
…hapes in Storage Update/improve docblocks for key functions Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
joshtrichards
added
3. to review
joshtrichards
added
2. developing
CarlSchwan
reviewed
Apr 10, 2026
| @@ -216,25 +229,25 @@ public static function store($filename) { | |||
| $versionManager->createVersion($user, $file); | |||
Member
There was a problem hiding this comment.
Suggested change
| $versionManager->createVersion($user, $file); | |
| $versionManager->createVersion($user, $file); | |
| return true; |
Comment on lines
+167
to
+169
| * @return false|null False if no version was created; null on successful creation | ||
| */ | ||
| public static function store($filename) { | ||
| public static function store(string $filename): false|null { |
Member
There was a problem hiding this comment.
Suggested change
| * @return false|null False if no version was created; null on successful creation | |
| */ | |
| public static function store($filename) { | |
| public static function store(string $filename): false|null { | |
| * @return bool Whether a version was created | |
| */ | |
| public static function store(string $filename): bool { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds conservative type declarations and improves phpdoc in
apps/files_versions/lib/Storage.php.Storageis a legacy static utility class with several mixed-return methods and loosely documented array shapes. This makes the API clearer for readers and static analysis while preserving existing behavior.What changed
Notes
No functional changes.
Preserves legacy mixed-return behavior in
store(),renameOrCopy(), andexpire()to ensure compatibility, but this should make future refactoring easier.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)