Skip to content

ci(workflows): send new issue notifications to app maintainers by app label#59752

Open
edward-ly wants to merge 1 commit into
masterfrom
chore/noid/notify-app-owners
Open

ci(workflows): send new issue notifications to app maintainers by app label#59752
edward-ly wants to merge 1 commit into
masterfrom
chore/noid/notify-app-owners

Conversation

@edward-ly
Copy link
Copy Markdown
Contributor

@edward-ly edward-ly commented Apr 20, 2026

Summary

Whenever a new issue for a particular app in this repository is created, this new workflow will send a GitHub notification to the appropriate app maintainer(s) by posting a comment in the issue mentioning them.

The current list of eligible apps only includes those for which a corresponding label already exists, but I am open to suggestions regarding what the final list should contain.

cc @DaphneMuller @janepie

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@edward-ly edward-ly requested a review from a team as a code owner April 20, 2026 23:17
@edward-ly edward-ly requested review from Altahrim, ArtificialOwl, icewind1991 and provokateurin and removed request for a team April 20, 2026 23:17
@edward-ly edward-ly added the 3. to review Waiting for reviews label Apr 20, 2026
Comment thread .github/workflows/notify-owners.yml Fixed
@edward-ly edward-ly force-pushed the chore/noid/notify-app-owners branch from cf263e9 to c43685b Compare April 20, 2026 23:26
… label

Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly force-pushed the chore/noid/notify-app-owners branch from c43685b to e693248 Compare April 20, 2026 23:28
@provokateurin
Copy link
Copy Markdown
Member

  1. Why do we do this?
  2. The app labels are not used enough to be reliable
  3. Why are not all apps listed there?

@edward-ly
Copy link
Copy Markdown
Contributor Author

edward-ly commented Apr 21, 2026

  1. Why do we do this?
  2. The app labels are not used enough to be reliable
  3. Why are not all apps listed there?
  1. Because each app has separate maintainers (some of whom are not in the files team), this addresses a concern where server issues related to a particular app could not be seen by the app's maintainers in a timely manner. Turning on notifications for the entire server repository is not feasible because that would introduce too much noise from all the other apps. Sorry I forgot to include that earlier.
  2. Then maybe we should enforce some kind of system that makes labels more reliable? Or at least something that helps send the right issues to the right people.
  3. I'm open to feedback on which apps should be included or not. I also considered adding labels for apps that don't already have one created for them, but I'm not sure who exactly has the authority to do that.

@edward-ly
Copy link
Copy Markdown
Contributor Author

Another potential alternative I just thought of would be to move each app out to separate repositories and re-add them as submodules instead, although I'm not sure yet if that'll affect other parts of the server in any way.

@DaphneMuller
Copy link
Copy Markdown

fyi @miaulalala
fyi @AndyScherzinger this is what we discussed a few months ago that people who maintain certain apps in the server repository struggle with getting notified of incoming issues & the solution Edward proposed that you approved

Copy link
Copy Markdown
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, we should give it a trial run if it helps.

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 21, 2026

But experts are not app maintainers. For example look at the files app, they both will drown in notifications.

That is the reason why we have github-teams for pull requests which assign people from the respective team in round-robin. While this might work for any other repository I highly doubt this will work for server.
I fear it just creates more noise so that notifications are even more ignored.

Please note that we already have a triaging

We already triage the server issues: 🧑‍🤝‍🧑 Community triage (view)
The triage list is quite empty to the process is working.

If your point is that you think some app owners should be pinged about their apps then, we can add this to the process and let them handle them their issues. But at least for the server team thats not how work is split.

@provokateurin
Copy link
Copy Markdown
Member

I fear it just creates more noise so that notifications are even more ignored.

If your point is that you think some app owners should be pinged about their apps then, we can add this to the process and let them handle them their issues. But at least for the server team thats not how work is split.

Fully agree with these two points.

@DaphneMuller
Copy link
Copy Markdown

The use case is that there are some server apps that are maintained by people in other teams. For example the comments app (maintained by Edward) and webhook listeners (maintained by Jana). So they need to get informed when there is a new issue for them. This must be a problem for many app maintainers that are not part of the files team. It's fine by me if this can be resolved by adjusting the triage process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants